2017-11-23 15:56:55

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 2/2] extcon: axp288:: Handle return value of platform_get_irq

platform_get_irq() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/extcon/extcon-axp288.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/extcon/extcon-axp288.c b/drivers/extcon/extcon-axp288.c
index 981fba5..e16a783 100644
--- a/drivers/extcon/extcon-axp288.c
+++ b/drivers/extcon/extcon-axp288.c
@@ -301,6 +301,9 @@ static int axp288_extcon_probe(struct platform_device *pdev)

for (i = 0; i < EXTCON_IRQ_END; i++) {
pirq = platform_get_irq(pdev, i);
+ if (pirq < 0)
+ return pirq;
+
info->irq[i] = regmap_irq_get_virq(info->regmap_irqc, pirq);
if (info->irq[i] < 0) {
dev_err(&pdev->dev,
--
2.7.4


From 1584390412136380619@xxx Sat Nov 18 08:07:23 +0000 2017
X-GM-THRID: 1584390412136380619
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread