2017-11-28 15:22:06

by Vasyl Gomonovych

[permalink] [raw]
Subject: [PATCH] misc: mic: Use PTR_ERR_OR_ZERO()

Fix ptr_ret.cocci warnings:
drivers/misc/mic/scif/scif_epd.h:168:1-3: WARNING: PTR_ERR_OR_ZERO can be used

Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vasyl Gomonovych <[email protected]>
---
drivers/misc/mic/scif/scif_epd.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/misc/mic/scif/scif_epd.h b/drivers/misc/mic/scif/scif_epd.h
index 1771d7a9b8d0..8dad98edeb56 100644
--- a/drivers/misc/mic/scif/scif_epd.h
+++ b/drivers/misc/mic/scif/scif_epd.h
@@ -165,9 +165,7 @@ static inline int scif_verify_epd(struct scif_endpt *ep)
static inline int scif_anon_inode_getfile(scif_epd_t epd)
{
epd->anon = anon_inode_getfile("scif", &scif_anon_fops, NULL, 0);
- if (IS_ERR(epd->anon))
- return PTR_ERR(epd->anon);
- return 0;
+ return PTR_ERR_OR_ZERO(epd->anon);
}

static inline void scif_anon_inode_fput(scif_epd_t epd)
--
1.9.1


From 1585313867436523461@xxx Tue Nov 28 12:45:18 +0000 2017
X-GM-THRID: 1585306279161286911
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread