2017-11-30 15:45:20

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH 1/3] iio: trigger: Fix platform_get_irq's error checking

The platform_get_irq() function returns negative if an error occurs.
zero or positive number on success. platform_get_irq() error checking
for zero is not correct.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/staging/iio/trigger/iio-trig-bfin-timer.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
index d80dcf8..f389f5c 100644
--- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
+++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
@@ -187,9 +187,9 @@ static int iio_bfin_tmr_trigger_probe(struct platform_device *pdev)
return -ENOMEM;

st->irq = platform_get_irq(pdev, 0);
- if (!st->irq) {
+ if (st->irq < 0) {
dev_err(&pdev->dev, "No IRQs specified");
- return -ENODEV;
+ return st->irq;
}

ret = iio_bfin_tmr_get_number(st->irq);
--
2.7.4


From 1585864896763535021@xxx Mon Dec 04 14:43:41 +0000 2017
X-GM-THRID: 1585864896763535021
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread