Hi Rasmus,
Apologies for the delayed follow-up on this.
On Tue, 2017-11-21 at 01:12 +0100, Rasmus Villemoes wrote:
> From: Rasmus Villemoes <[email protected]>
>
> iscsi_parse_pr_out_transport_id launders the const away via a call to
> strstr(), and then modifies the buffer (writing a nul byte) through
> the return value. It's cleaner to be honest and simply declare the
> parameter as "char*", fixing up the call chain, and allowing us to
> drop the cast in the return statement.
>
> Amusingly, the two current callers found it necessary to cast a
> non-const pointer to a const.
>
> Signed-off-by: Rasmus Villemoes <[email protected]>
> ---
> drivers/target/target_core_fabric_lib.c | 6 +++---
> drivers/target/target_core_internal.h | 2 +-
> drivers/target/target_core_pr.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
Looks fine. Applied.
Thank you.