2018-01-31 04:38:13

by Yisheng Xie

Subject: [PATCH] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings

ion_buffer_fault_user_mappings's definition has been removed and not be
used anymore, just remove its useless declaration.

Signed-off-by: Yisheng Xie <[email protected]>
---
drivers/staging/android/ion/ion.h | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
index f5f9cd6..2160c35 100644
--- a/drivers/staging/android/ion/ion.h
+++ b/drivers/staging/android/ion/ion.h
@@ -201,15 +201,6 @@ struct ion_heap {
bool ion_buffer_cached(struct ion_buffer *buffer);

/**
- * ion_buffer_fault_user_mappings - fault in user mappings of this buffer
- * @buffer: buffer
- *
- * indicates whether userspace mappings of this buffer will be faulted
- * in, this can affect how buffers are allocated from the heap.
- */
-bool ion_buffer_fault_user_mappings(struct ion_buffer *buffer);
-
-/**
* ion_device_add_heap - adds a heap to the ion device
* @heap: the heap to add
*/
--
1.7.12.4

2018-02-06 22:51:25

by Laura Abbott

Subject: Re: [PATCH] staging: android: ion: Remove unused declaration ion_buffer_fault_user_mappings

On 01/30/2018 08:01 PM, Yisheng Xie wrote:
> ion_buffer_fault_user_mappings's definition has been removed and not be
> used anymore, just remove its useless declaration.
>

Acked-by: Laura Abbott <[email protected]>

> Signed-off-by: Yisheng Xie <[email protected]>
> ---
> drivers/staging/android/ion/ion.h | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/staging/android/ion/ion.h b/drivers/staging/android/ion/ion.h
> index f5f9cd6..2160c35 100644
> --- a/drivers/staging/android/ion/ion.h
> +++ b/drivers/staging/android/ion/ion.h
> @@ -201,15 +201,6 @@ struct ion_heap {
> bool ion_buffer_cached(struct ion_buffer *buffer);
>
> /**
> - * ion_buffer_fault_user_mappings - fault in user mappings of this buffer
> - * @buffer: buffer
> - *
> - * indicates whether userspace mappings of this buffer will be faulted
> - * in, this can affect how buffers are allocated from the heap.
> - */
> -bool ion_buffer_fault_user_mappings(struct ion_buffer *buffer);
> -
> -/**
> * ion_device_add_heap - adds a heap to the ion device
> * @heap: the heap to add
> */
>