2018-03-09 13:28:02

by Mohammed Gamal

Subject: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

Commit 009f766 intended to filter multicast/broadcast, however
the NDIS filter wasn't set properly in non-promiscuous modes,
which resulted in issues like DHCP timeouts.
This patch sets the filter flags correctly.

Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")

Signed-off-by: Mohammed Gamal <[email protected]>
---
drivers/net/hyperv/rndis_filter.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 8927c48..411a3ae 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -861,9 +861,9 @@ static void rndis_set_multicast(struct work_struct *w)
filter = NDIS_PACKET_TYPE_PROMISCUOUS;
} else {
if (flags & IFF_ALLMULTI)
- flags |= NDIS_PACKET_TYPE_ALL_MULTICAST;
+ filter |= NDIS_PACKET_TYPE_ALL_MULTICAST;
if (flags & IFF_BROADCAST)
- flags |= NDIS_PACKET_TYPE_BROADCAST;
+ filter |= NDIS_PACKET_TYPE_BROADCAST;
}

rndis_filter_set_packet_filter(rdev, filter);
--
1.8.3.1

2018-03-09 15:18:05

by David Miller

Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

From: Mohammed Gamal <[email protected]>
Date: Fri, 9 Mar 2018 12:22:22 +0100

> Commit 009f766 intended to filter multicast/broadcast, however
> it did cause DHCP timeouts. A closer look showed that the filters
> were not set properly causing this issue.
>
> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
>
> Signed-off-by: Mohammed Gamal <[email protected]>

This is fixed already in the net tree.

2018-03-09 18:38:24

by Sergei Shtylyov

Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

Hello!

On 03/09/2018 04:25 PM, Mohammed Gamal wrote:

> Commit 009f766 intended to filter multicast/broadcast, however

At least 12 digits needed here, and the summary line too, just like you do
for the Fixes: tag.

> the NDIS filter wasn't set properly in non-promiscuous modes,
> which resulted in issues like DHCP timeouts.
> This patch sets the filter flags correctly.
>
> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")
>
> Signed-off-by: Mohammed Gamal <[email protected]>
[...]
MBR, Sergei

2018-03-09 18:40:49

by Sergei Shtylyov

Subject: Re: [PATCH net-next] hv_netvsc: Correct filter setting for multicast/broadcast

On 03/09/2018 09:37 PM, Sergei Shtylyov wrote:

>> Commit 009f766 intended to filter multicast/broadcast, however
>
> At least 12 digits needed here, and the summary line too, just like you do
> for the Fixes: tag.
>
>> the NDIS filter wasn't set properly in non-promiscuous modes,
>> which resulted in issues like DHCP timeouts.
>> This patch sets the filter flags correctly.
>>
>> Fixes: 009f766 ("hv_netvsc: filter multicast/broadcast")

12 digits needed here as well.

>>
>> Signed-off-by: Mohammed Gamal <[email protected]>

> [...]

MBR, Sergei