2018-04-18 15:48:46

by Fabrice Gasnier

[permalink] [raw]
Subject: [PATCH] ARM: dts: stm32: Add DAC support to stm32mp157c

Add support for DAC (Digital to Analog Converter) to STM32MP157C.
STM32MP157C DAC has two output channels.

Signed-off-by: Fabrice Gasnier <[email protected]>
---
arch/arm/boot/dts/stm32mp157c.dtsi | 24 ++++++++++++++++++++++++
1 file changed, 24 insertions(+)

diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
index bc3eddc..fd44b4d 100644
--- a/arch/arm/boot/dts/stm32mp157c.dtsi
+++ b/arch/arm/boot/dts/stm32mp157c.dtsi
@@ -136,6 +136,30 @@
status = "disabled";
};

+ dac: dac@40017000 {
+ compatible = "st,stm32h7-dac-core";
+ reg = <0x40017000 0x400>;
+ clocks = <&rcc DAC12>;
+ clock-names = "pclk";
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+
+ dac1: dac@1 {
+ compatible = "st,stm32-dac";
+ #io-channels-cells = <1>;
+ reg = <1>;
+ status = "disabled";
+ };
+
+ dac2: dac@2 {
+ compatible = "st,stm32-dac";
+ #io-channels-cells = <1>;
+ reg = <2>;
+ status = "disabled";
+ };
+ };
+
uart7: serial@40018000 {
compatible = "st,stm32h7-uart";
reg = <0x40018000 0x400>;
--
1.9.1



2018-04-19 17:04:55

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: stm32: Add DAC support to stm32mp157c

Hi Fabrice,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.17-rc1 next-20180419]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Fabrice-Gasnier/ARM-dts-stm32-Add-DAC-support-to-stm32mp157c/20180419-211311
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: arm-moxart_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=arm

All errors (new ones prefixed by >>):

>> Error: arch/arm/boot/dts/stm32mp157c.dtsi:165.19-20 syntax error
FATAL ERROR: Unable to parse input tree

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation


Attachments:
(No filename) (1.12 kB)
.config.gz (12.03 kB)
Download all attachments

2018-05-02 12:28:02

by Alexandre Torgue

[permalink] [raw]
Subject: Re: [PATCH] ARM: dts: stm32: Add DAC support to stm32mp157c

Hi Fabrice

On 04/18/2018 05:46 PM, Fabrice Gasnier wrote:
> Add support for DAC (Digital to Analog Converter) to STM32MP157C.
> STM32MP157C DAC has two output channels.
>
> Signed-off-by: Fabrice Gasnier <[email protected]>
> ---
> arch/arm/boot/dts/stm32mp157c.dtsi | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi
> index bc3eddc..fd44b4d 100644
> --- a/arch/arm/boot/dts/stm32mp157c.dtsi
> +++ b/arch/arm/boot/dts/stm32mp157c.dtsi
> @@ -136,6 +136,30 @@
> status = "disabled";
> };
>
> + dac: dac@40017000 {
> + compatible = "st,stm32h7-dac-core";
> + reg = <0x40017000 0x400>;
> + clocks = <&rcc DAC12>;
> + clock-names = "pclk";
> + #address-cells = <1>;
> + #size-cells = <0>;
> + status = "disabled";
> +
> + dac1: dac@1 {
> + compatible = "st,stm32-dac";
> + #io-channels-cells = <1>;
> + reg = <1>;
> + status = "disabled";
> + };
> +
> + dac2: dac@2 {
> + compatible = "st,stm32-dac";
> + #io-channels-cells = <1>;
> + reg = <2>;
> + status = "disabled";
> + };
> + };
> +
> uart7: serial@40018000 {
> compatible = "st,stm32h7-uart";
> reg = <0x40018000 0x400>;
>

Applied on stm32-next.

Thanks.
Alex