LinuxLists.cc - linux-next: Signed-off-by missing for commits in the thermal tree

2018-05-09 11:44:11

Subject: linux-next: Signed-off-by missing for commits in the thermal tree

Hi Zhang,

Commits

a2ace598c00a ("thermal: exynos: Reading temperature makes sense only when TMU is turned on")
f9cd6a904e6e ("thermal: exynos: Propagate error value from tmu_read()")

are missing a Signed-off-by from their committer.

--
Cheers,
Stephen Rothwell

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2018-05-10 02:12:32

by Eduardo Valentin

[permalink] [raw]

Subject: Re: linux-next: Signed-off-by missing for commits in the thermal tree

Hey Rui,

On Wed, May 09, 2018 at 09:43:41PM +1000, Stephen Rothwell wrote:
> Hi Zhang,
>
> Commits
>
> a2ace598c00a ("thermal: exynos: Reading temperature makes sense only when TMU is turned on")
> f9cd6a904e6e ("thermal: exynos: Propagate error value from tmu_read()")
>
> are missing a Signed-off-by from their committer.

Did you cherry-pick them instead of merging? If cherry-picking you have
to add your Signed-off-by..

>
> --
> Cheers,
> Stephen Rothwell

2018-05-11 01:54:07

by Zhang, Rui

[permalink] [raw]

Subject: Re: linux-next: Signed-off-by missing for commits in the thermal tree

On 三, 2018-05-09 at 19:10 -0700, Eduardo Valentin wrote:
> Hey Rui,
>
> On Wed, May 09, 2018 at 09:43:41PM +1000, Stephen Rothwell wrote:
> >
> > Hi Zhang,
> >
> > Commits
> >
> > a2ace598c00a ("thermal: exynos: Reading temperature makes sense
> > only when TMU is turned on")
> > f9cd6a904e6e ("thermal: exynos: Propagate error value from
> > tmu_read()")
> >
> > are missing a Signed-off-by from their committer.
> Did you cherry-pick them instead of merging? If cherry-picking you
> have
> to add your Signed-off-by..
>
I merged them, and then did a rebase to drop some of the patch, hmmm,
could that be the problem?
Anyway, I will re-merge your tree and push them out sometime tomorrow.

thanks,
rui