2018-07-20 07:17:55

by Fabrice Gasnier

[permalink] [raw]
Subject: [PATCH] pwm: stm32-lp: Remove useless loop in stm32_pwm_lp_remove()

LPTimer has only one pwm channel (npwm = 1). Remove useless for loop
in remove routine.

Signed-off-by: Fabrice Gasnier <[email protected]>
---
drivers/pwm/pwm-stm32-lp.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pwm/pwm-stm32-lp.c b/drivers/pwm/pwm-stm32-lp.c
index 7c13e25..0059b24c 100644
--- a/drivers/pwm/pwm-stm32-lp.c
+++ b/drivers/pwm/pwm-stm32-lp.c
@@ -217,10 +217,8 @@ static int stm32_pwm_lp_probe(struct platform_device *pdev)
static int stm32_pwm_lp_remove(struct platform_device *pdev)
{
struct stm32_pwm_lp *priv = platform_get_drvdata(pdev);
- unsigned int i;

- for (i = 0; i < priv->chip.npwm; i++)
- pwm_disable(&priv->chip.pwms[i]);
+ pwm_disable(&priv->chip.pwms[0]);

return pwmchip_remove(&priv->chip);
}
--
1.9.1



2018-08-20 09:32:30

by Thierry Reding

[permalink] [raw]
Subject: Re: [PATCH] pwm: stm32-lp: Remove useless loop in stm32_pwm_lp_remove()

On Fri, Jul 20, 2018 at 09:16:32AM +0200, Fabrice Gasnier wrote:
> LPTimer has only one pwm channel (npwm = 1). Remove useless for loop
> in remove routine.
>
> Signed-off-by: Fabrice Gasnier <[email protected]>
> ---
> drivers/pwm/pwm-stm32-lp.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks.

Thierry


Attachments:
(No filename) (352.00 B)
signature.asc (849.00 B)
Download all attachments