2018-08-15 01:48:25

by Dongli Zhang

Subject: [PATCH 1/1] vhost: change the signature of __vhost_get_user_slow()

Remove 'type' from the signature of __vhost_get_user_slow() as it is not
used.

Signed-off-by: Dongli Zhang <[email protected]>
---
drivers/vhost/vhost.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
index ed31145..f78d3bc 100644
--- a/drivers/vhost/vhost.c
+++ b/drivers/vhost/vhost.c
@@ -807,8 +807,7 @@ static int vhost_copy_from_user(struct vhost_virtqueue *vq, void *to,
}

static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
- void __user *addr, unsigned int size,
- int type)
+ void __user *addr, unsigned int size)
{
int ret;

@@ -846,7 +845,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
if (uaddr)
return uaddr;

- return __vhost_get_user_slow(vq, addr, size, type);
+ return __vhost_get_user_slow(vq, addr, size);
}

#define vhost_put_user(vq, x, ptr) \
--
2.7.4

2018-08-15 03:24:05

by Jason Wang

Subject: Re: [PATCH 1/1] vhost: change the signature of __vhost_get_user_slow()

On 2018年08月15日 09:46, Dongli Zhang wrote:
> Remove 'type' from the signature of __vhost_get_user_slow() as it is not
> used.
>
> Signed-off-by: Dongli Zhang <[email protected]>
> ---
> drivers/vhost/vhost.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/vhost/vhost.c b/drivers/vhost/vhost.c
> index ed31145..f78d3bc 100644
> --- a/drivers/vhost/vhost.c
> +++ b/drivers/vhost/vhost.c
> @@ -807,8 +807,7 @@ static int vhost_copy_from_user(struct vhost_virtqueue *vq, void *to,
> }
>
> static void __user *__vhost_get_user_slow(struct vhost_virtqueue *vq,
> - void __user *addr, unsigned int size,
> - int type)
> + void __user *addr, unsigned int size)
> {
> int ret;
>
> @@ -846,7 +845,7 @@ static inline void __user *__vhost_get_user(struct vhost_virtqueue *vq,
> if (uaddr)
> return uaddr;
>
> - return __vhost_get_user_slow(vq, addr, size, type);
> + return __vhost_get_user_slow(vq, addr, size);
> }
>
> #define vhost_put_user(vq, x, ptr) \

Please keep this as is.

It will be used by incoming packed virtqueue.

Thanks