2018-09-19 14:49:18

by zhong jiang

Subject: [PATCH] drm: nouveau: remove a redundant local variable 'pclks'

The local variable 'pclks' is never used after being assigned.
hence it should be redundant and can be removed.

Signed-off-by: zhong jiang <[email protected]>
---
drivers/gpu/drm/nouveau/dispnv04/arb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c b/drivers/gpu/drm/nouveau/dispnv04/arb.c
index c79160c..cae8f71 100644
--- a/drivers/gpu/drm/nouveau/dispnv04/arb.c
+++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c
@@ -56,7 +56,7 @@ struct nv_sim_state {
nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state *arb)
{
int pagemiss, cas, width, bpp;
- int nvclks, mclks, pclks, crtpagemiss;
+ int nvclks, mclks, crtpagemiss;
int found, mclk_extra, mclk_loop, cbs, m1, p1;
int mclk_freq, pclk_freq, nvclk_freq;
int us_m, us_n, us_p, crtc_drain_rate;
@@ -71,7 +71,6 @@ struct nv_sim_state {
bpp = arb->bpp;
cbs = 128;

- pclks = 2;
nvclks = 10;
mclks = 13 + cas;
mclk_extra = 3;
--
1.7.12.4

2018-09-19 17:26:52

by Lyude Paul

Subject: Re: [Nouveau] [PATCH] drm: nouveau: remove a redundant local variable 'pclks'

lgtm

Reviewed-by: Lyude Paul <[email protected]>

On Wed, 2018-09-19 at 22:36 +0800, zhong jiang wrote:
> The local variable 'pclks' is never used after being assigned.
> hence it should be redundant and can be removed.
>
> Signed-off-by: zhong jiang <[email protected]>
> ---
> drivers/gpu/drm/nouveau/dispnv04/arb.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/dispnv04/arb.c
> b/drivers/gpu/drm/nouveau/dispnv04/arb.c
> index c79160c..cae8f71 100644
> --- a/drivers/gpu/drm/nouveau/dispnv04/arb.c
> +++ b/drivers/gpu/drm/nouveau/dispnv04/arb.c
> @@ -56,7 +56,7 @@ struct nv_sim_state {
> nv04_calc_arb(struct nv_fifo_info *fifo, struct nv_sim_state *arb)
> {
> int pagemiss, cas, width, bpp;
> - int nvclks, mclks, pclks, crtpagemiss;
> + int nvclks, mclks, crtpagemiss;
> int found, mclk_extra, mclk_loop, cbs, m1, p1;
> int mclk_freq, pclk_freq, nvclk_freq;
> int us_m, us_n, us_p, crtc_drain_rate;
> @@ -71,7 +71,6 @@ struct nv_sim_state {
> bpp = arb->bpp;
> cbs = 128;
>
> - pclks = 2;
> nvclks = 10;
> mclks = 13 + cas;
> mclk_extra = 3;