From: Peng Hao <[email protected]>
tick_device_is_functional() has been called in the front of
tick_broadcast_control, so don't need call it again.
Signed-off-by: Peng Hao <[email protected]>
---
kernel/time/tick-broadcast.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index aa2094d..74637c2 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -399,9 +399,7 @@ void tick_broadcast_control(enum tick_broadcast_mode mode)
case TICK_BROADCAST_OFF:
if (tick_broadcast_forced)
break;
- cpumask_clear_cpu(cpu, tick_broadcast_on);
- if (!tick_device_is_functional(dev))
- break;
+ cpumask_clear_cpu(cpu, tick_broadcast_on);
if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) {
if (tick_broadcast_device.mode ==
TICKDEV_MODE_PERIODIC)
--
1.8.3.1
Commit-ID: dc6253108f0fbff4a634055d5b8a91958ec2af81
Gitweb: https://git.kernel.org/tip/dc6253108f0fbff4a634055d5b8a91958ec2af81
Author: Peng Hao <[email protected]>
AuthorDate: Fri, 28 Sep 2018 12:03:28 -0400
Committer: Thomas Gleixner <[email protected]>
CommitDate: Fri, 28 Sep 2018 22:29:35 +0200
tick/broadcast: Remove redundant check
tick_device_is_functional() is called early in tick_broadcast_control(), so
no need to call it again later.
Signed-off-by: Peng Hao <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Cc: [email protected]
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/time/tick-broadcast.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/kernel/time/tick-broadcast.c b/kernel/time/tick-broadcast.c
index aa2094d5dd27..be0aac2b4300 100644
--- a/kernel/time/tick-broadcast.c
+++ b/kernel/time/tick-broadcast.c
@@ -400,8 +400,6 @@ void tick_broadcast_control(enum tick_broadcast_mode mode)
if (tick_broadcast_forced)
break;
cpumask_clear_cpu(cpu, tick_broadcast_on);
- if (!tick_device_is_functional(dev))
- break;
if (cpumask_test_and_clear_cpu(cpu, tick_broadcast_mask)) {
if (tick_broadcast_device.mode ==
TICKDEV_MODE_PERIODIC)