2018-11-10 02:48:48

by Yue Haibing

Subject: [PATCH -next] drm/sti: remove set but not used variable 'priv'

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
variable 'priv' set but not used [-Wunused-but-set-variable]

It never used since introduction in
9e1f05b28009 ("drm/sti: rename files and functions")

Signed-off-by: YueHaibing <[email protected]>
---
drivers/gpu/drm/sti/sti_crtc.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
index 61c2379..ed76e52e 100644
--- a/drivers/gpu/drm/sti/sti_crtc.c
+++ b/drivers/gpu/drm/sti/sti_crtc.c
@@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
struct sti_compositor *compo;
struct drm_crtc *crtc = data;
struct sti_mixer *mixer;
- struct sti_private *priv;
unsigned int pipe;

- priv = crtc->dev->dev_private;
pipe = drm_crtc_index(crtc);
compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
mixer = compo->mixer[pipe];

2018-11-13 11:10:07

by Benjamin Gaignard

Subject: Re: [PATCH -next] drm/sti: remove set but not used variable 'priv'

Le sam. 10 nov. 2018 à 03:48, YueHaibing <[email protected]> a écrit :
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/sti/sti_crtc.c: In function 'sti_crtc_vblank_cb':
> drivers/gpu/drm/sti/sti_crtc.c:255:22: warning:
> variable 'priv' set but not used [-Wunused-but-set-variable]
>
> It never used since introduction in
> 9e1f05b28009 ("drm/sti: rename files and functions")
>
> Signed-off-by: YueHaibing <[email protected]>

Applied on drm-misc-next.

Thanks,
Benjamin

> ---
> drivers/gpu/drm/sti/sti_crtc.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crtc.c
> index 61c2379..ed76e52e 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -252,10 +252,8 @@ int sti_crtc_vblank_cb(struct notifier_block *nb,
> struct sti_compositor *compo;
> struct drm_crtc *crtc = data;
> struct sti_mixer *mixer;
> - struct sti_private *priv;
> unsigned int pipe;
>
> - priv = crtc->dev->dev_private;
> pipe = drm_crtc_index(crtc);
> compo = container_of(nb, struct sti_compositor, vtg_vblank_nb[pipe]);
> mixer = compo->mixer[pipe];
>
>
>