2018-11-28 06:56:08

by Pan Bian

Subject: [PATCH] rapidio/rionet: do not free skb before reading its length

skb is freed via dev_kfree_skb_any, however, skb->len is read then. This
may result in a use-after-free bug.

Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal")
Signed-off-by: Pan Bian <[email protected]>
---
drivers/net/rionet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/rionet.c b/drivers/net/rionet.c
index e9f101c..bfbb39f 100644
--- a/drivers/net/rionet.c
+++ b/drivers/net/rionet.c
@@ -216,9 +216,9 @@ static int rionet_start_xmit(struct sk_buff *skb, struct net_device *ndev)
* it just report sending a packet to the target
* (without actual packet transfer).
*/
- dev_kfree_skb_any(skb);
ndev->stats.tx_packets++;
ndev->stats.tx_bytes += skb->len;
+ dev_kfree_skb_any(skb);
}
}

--
2.7.4

2018-11-28 18:43:08

by David Miller

Subject: Re: [PATCH] rapidio/rionet: do not free skb before reading its length

From: Pan Bian <[email protected]>
Date: Wed, 28 Nov 2018 14:53:19 +0800

> skb is freed via dev_kfree_skb_any, however, skb->len is read then. This
> may result in a use-after-free bug.
>
> Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal")
> Signed-off-by: Pan Bian <[email protected]>

Applied and queued up for -stable.