2019-06-19 07:52:31

by Dongli Zhang

[permalink] [raw]
Subject: [PATCH 1/1] scsi: virtio_scsi: remove unused 'affinity_hint_set'

The 'affinity_hint_set' is not used any longer since
commit 0d9f0a52c8b9 ("virtio_scsi: use virtio IRQ affinity").

Signed-off-by: Dongli Zhang <[email protected]>
---
drivers/scsi/virtio_scsi.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
index 13f1b3b..1705398 100644
--- a/drivers/scsi/virtio_scsi.c
+++ b/drivers/scsi/virtio_scsi.c
@@ -74,9 +74,6 @@ struct virtio_scsi {

u32 num_queues;

- /* If the affinity hint is set for virtqueues */
- bool affinity_hint_set;
-
struct hlist_node node;

/* Protected by event_vq lock */
--
2.7.4


2019-06-19 10:24:18

by Paolo Bonzini

[permalink] [raw]
Subject: Re: [PATCH 1/1] scsi: virtio_scsi: remove unused 'affinity_hint_set'

On 19/06/19 09:52, Dongli Zhang wrote:
> The 'affinity_hint_set' is not used any longer since
> commit 0d9f0a52c8b9 ("virtio_scsi: use virtio IRQ affinity").
>
> Signed-off-by: Dongli Zhang <[email protected]>
> ---
> drivers/scsi/virtio_scsi.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c
> index 13f1b3b..1705398 100644
> --- a/drivers/scsi/virtio_scsi.c
> +++ b/drivers/scsi/virtio_scsi.c
> @@ -74,9 +74,6 @@ struct virtio_scsi {
>
> u32 num_queues;
>
> - /* If the affinity hint is set for virtqueues */
> - bool affinity_hint_set;
> -
> struct hlist_node node;
>
> /* Protected by event_vq lock */
>

Acked-by: Paolo Bonzini <[email protected]>

2019-06-20 21:53:59

by Martin K. Petersen

[permalink] [raw]
Subject: Re: [PATCH 1/1] scsi: virtio_scsi: remove unused 'affinity_hint_set'


Dongli,

> The 'affinity_hint_set' is not used any longer since
> commit 0d9f0a52c8b9 ("virtio_scsi: use virtio IRQ affinity").

Applied to 5.3/scsi-queue. Thanks!

--
Martin K. Petersen Oracle Linux Engineering