Add missing vdda-supply, analog power supply, to STM32 ADC. When vdda is
an independent supply, it needs to be properly turned on or off to supply
the ADC.
This series proposes fixes for the dt-bindings, IIO driver and relevant
device tree files.
Fabrice Gasnier (5):
dt-bindings: iio: adc: stm32: add missing vdda supply
iio: adc: stm32-adc: add missing vdda-supply
ARM: dts: stm32: remove fixed regulator unit address on stm32429i-eval
ARM: dts: stm32: add missing vdda-supply to adc on stm32429i-eval
ARM: dts: stm32: add missing vdda-supply to adc on stm32h743i-eval
.../devicetree/bindings/iio/adc/st,stm32-adc.txt | 1 +
arch/arm/boot/dts/stm32429i-eval.dts | 25 +++++++++++-----------
arch/arm/boot/dts/stm32h743i-eval.dts | 1 +
drivers/iio/adc/stm32-adc-core.c | 21 +++++++++++++++++-
4 files changed, 35 insertions(+), 13 deletions(-)
--
2.7.4
vref fixed regulator shouldn't have unit address and reg properties.
Rename the label and phandle to "vref" according to the schematics.
Also remove it from simple-bus.
Fixes: 7465d81191a1 ("ARM: dts: stm32: enable ADC on stm32f429i-eval
board")
Signed-off-by: Fabrice Gasnier <[email protected]>
---
arch/arm/boot/dts/stm32429i-eval.dts | 18 ++++++------------
1 file changed, 6 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts
index 73ea84d..d79f58f 100644
--- a/arch/arm/boot/dts/stm32429i-eval.dts
+++ b/arch/arm/boot/dts/stm32429i-eval.dts
@@ -81,18 +81,12 @@
dma-ranges = <0xc0000000 0x0 0x10000000>;
};
- regulators {
- compatible = "simple-bus";
- #address-cells = <1>;
- #size-cells = <0>;
- reg_vref: regulator@0 {
- compatible = "regulator-fixed";
- reg = <0>;
- regulator-name = "vref";
- regulator-min-microvolt = <3300000>;
- regulator-max-microvolt = <3300000>;
- };
+ vref: regulator-vref {
+ compatible = "regulator-fixed";
+ regulator-name = "vref";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
};
leds {
@@ -157,7 +151,7 @@
&adc {
pinctrl-names = "default";
pinctrl-0 = <&adc3_in8_pin>;
- vref-supply = <®_vref>;
+ vref-supply = <&vref>;
status = "okay";
adc3: adc@200 {
st,adc-channels = <8>;
--
2.7.4
Add missing vdda-supply required by STM32 ADC.
Fixes: 090992a9ca54 ("ARM: dts: stm32: enable ADC on stm32h743i-eval
board")
Signed-off-by: Fabrice Gasnier <[email protected]>
---
arch/arm/boot/dts/stm32h743i-eval.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/boot/dts/stm32h743i-eval.dts b/arch/arm/boot/dts/stm32h743i-eval.dts
index ab78ad5..e4d3c58 100644
--- a/arch/arm/boot/dts/stm32h743i-eval.dts
+++ b/arch/arm/boot/dts/stm32h743i-eval.dts
@@ -87,6 +87,7 @@
};
&adc_12 {
+ vdda-supply = <&vdda>;
vref-supply = <&vdda>;
status = "okay";
adc1: adc@0 {
--
2.7.4
Hi Fabrice
On 6/19/19 2:29 PM, Fabrice Gasnier wrote:
> Add missing vdda-supply, analog power supply, to STM32 ADC. When vdda is
> an independent supply, it needs to be properly turned on or off to supply
> the ADC.
> This series proposes fixes for the dt-bindings, IIO driver and relevant
> device tree files.
>
> Fabrice Gasnier (5):
> dt-bindings: iio: adc: stm32: add missing vdda supply
> iio: adc: stm32-adc: add missing vdda-supply
> ARM: dts: stm32: remove fixed regulator unit address on stm32429i-eval
> ARM: dts: stm32: add missing vdda-supply to adc on stm32429i-eval
> ARM: dts: stm32: add missing vdda-supply to adc on stm32h743i-eval
>
> .../devicetree/bindings/iio/adc/st,stm32-adc.txt | 1 +
> arch/arm/boot/dts/stm32429i-eval.dts | 25 +++++++++++-----------
> arch/arm/boot/dts/stm32h743i-eval.dts | 1 +
> drivers/iio/adc/stm32-adc-core.c | 21 +++++++++++++++++-
> 4 files changed, 35 insertions(+), 13 deletions(-)
>
DT patches applied on stm32-next. I plan to add them in my PR for v5.4.
However those patches are marked as "fixes", do you see an issue to only
send it for v5.4 ?
Regards
alex