This patch set addresses some of the feedback received on the dpaa2-ethsw
driver: https://lore.kernel.org/patchwork/patch/1113335/.
There are no functional changes but rather just code cleanup.
Ioana Ciornei (10):
staging: fsl-dpaa2/ethsw: remove IGMP default address
staging: fsl-dpaa2/ethsw: enable switch ports only on dev_open
staging: fsl-dpaa2/ethsw: add line terminator to all formats
staging: fsl-dpaa2/ethsw: remove debug message
staging: fsl-dpaa2/ethsw: use bool when encoding learning/flooding
state
staging: fsl-dpaa2/ethsw: remove unnecessary memset
staging: fsl-dpaa2/ethsw: remove redundant VLAN check
staging: fsl-dpaa2/ethsw: reword error message
staging: fsl-dpaa2/ethsw: register_netdev only when ready
staging: fsl-dpaa2/ethsw: do not force user to bring interface down
drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 44 +++++-----
drivers/staging/fsl-dpaa2/ethsw/ethsw.c | 110 ++++++------------------
2 files changed, 50 insertions(+), 104 deletions(-)
--
1.9.1
Since ethtool will be loud enough if the .set_link_ksettings() callback
fails, remove the debug messages which do not add additional
information.
Signed-off-by: Ioana Ciornei <[email protected]>
---
drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
index 95e9f1096999..12e33a3a1bf1 100644
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw-ethtool.c
@@ -91,8 +91,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev,
struct dpsw_link_cfg cfg = {0};
int err = 0;
- netdev_dbg(netdev, "Setting link parameters...");
-
/* Due to a temporary MC limitation, the DPSW port must be down
* in order to be able to change link settings. Taking steps to let
* the user know that.
@@ -116,11 +114,6 @@ static void ethsw_get_drvinfo(struct net_device *netdev,
port_priv->ethsw_data->dpsw_handle,
port_priv->idx,
&cfg);
- if (err)
- /* ethtool will be loud enough if we return an error; no point
- * in putting our own error message on the console by default
- */
- netdev_dbg(netdev, "ERROR %d setting link cfg", err);
return err;
}
--
1.9.1