2019-09-26 10:56:30

by Sam Shih

[permalink] [raw]
Subject: [PATCH v10 0/12] Add mt7629 and fix mt7628 pwm

Changes since v10
1. Follow reviewers's comments:
- derive the number of PWMs from the specific compatible string
2. Add mt7629 pwm description
3. Add mt7628 fixed-clock description

Changes since v9:
1. PATCH 03/11: Add an Acked-by tag

Changes since v8:
1. Fix warning and build-error for patch 04/11

Changes since v7:
1. PATCH v7 10/11: Add a missed Reviewed-by tag

Changes since v6:
1. Due to we can use fixed-clock in DT
We removed has_clks and fixed-clock properties

Changes since v5:
- Follow reviewer's comments:
1. the license stuff is a separate change
2. split fix mt7628 pwm into a single patch
3. to ensure to not use mtk_pwm_clk_name[10]
(After dynamic allocate clock array patch,
this is no need to check)
4. Use clock-frequency property to replace
the use of has_clks

Changes since v4:
- Follow reviewer's comments (v3: pwm: mediatek: add a property "num-pwms")
Move the changes of droping the check for of_device_get_match_data
returning non-NULL to next patch
- Follow reviewers's comments
(v3: pwm: mediatek: allocate the clks array dynamically)
1. use pc->soc->has_clks to check clocks exist or not.
2. Add error message when probe() unable to get clks
- Fixes bug when SoC is old mips which has no complex clock tree.
if clocks not exist, use the new property from DT to apply period
calculation; otherwise, use clk_get_rate to get clock frequency and
apply period calculation.

Changes since v3:
- add a new property "clock-frequency" and fix mt7628 pwm
- add mt7629 pwm support

Changes since v2:
- use num-pwms instead of mediatek,num-pwms.
- rename the member from num_pwms to fallback_num_pwms to make it
more obvious that it doesn't represent the actually used value.
- add a dev_warn and a expressive comment to help other developers
to not start adding num_pwms in the compatible_data.

Changes since v1:
- add some checks for backwards compatibility.



Ryder Lee (5):
pwm: mediatek: add a property "num-pwms"
dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"
arm64: dts: mt7622: add a property "num-pwms" for PWM
arm: dts: mt7623: add a property "num-pwms" for PWM
dt-bindings: pwm: update bindings for MT7629 SoC

Sam Shih (7):
pwm: mediatek: droping the check for of_device_get_match_data
pwm: mediatek: remove a property "has-clks"
pwm: mediatek: allocate the clks array dynamically
pwm: mediatek: use pwm_mediatek as common prefix
pwm: mediatek: update license and switch to SPDX tag
pwm: mediatek: Add MT7629 compatible string
arm: dts: mediatek: add mt7629 pwm support

.../devicetree/bindings/pwm/pwm-mediatek.txt | 11 +-
arch/arm/boot/dts/mt7623.dtsi | 1 +
arch/arm/boot/dts/mt7629.dtsi | 15 ++
arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 +
drivers/pwm/pwm-mediatek.c | 249 +++++++++---------
5 files changed, 155 insertions(+), 122 deletions(-)

--
2.17.1


2019-09-26 10:56:55

by Sam Shih

[permalink] [raw]
Subject: [PATCH v10 06/12] pwm: mediatek: update license and switch to SPDX tag

Add SPDX identifiers to pwm-mediatek.c
Update license to GNU General Public License v2.0

Signed-off-by: Ryder Lee <[email protected]>
Signed-off-by: Sam Shih <[email protected]>
Reviewed-by: Uwe Kleine-König <[email protected]>
---
Changes since v6:
Add a Reviewed-by tag

Changes since v5:
- Follow reviewers's comments
The license stuff is a separate change

---
drivers/pwm/pwm-mediatek.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-mediatek.c b/drivers/pwm/pwm-mediatek.c
index 2db17d6b6ae1..ce7525d8d71b 100644
--- a/drivers/pwm/pwm-mediatek.c
+++ b/drivers/pwm/pwm-mediatek.c
@@ -1,12 +1,10 @@
+// SPDX-License-Identifier: GPL-2.0
/*
- * Mediatek Pulse Width Modulator driver
+ * MediaTek Pulse Width Modulator driver
*
* Copyright (C) 2015 John Crispin <[email protected]>
* Copyright (C) 2017 Zhi Mao <[email protected]>
*
- * This file is licensed under the terms of the GNU General Public
- * License version 2. This program is licensed "as is" without any
- * warranty of any kind, whether express or implied.
*/

#include <linux/err.h>
@@ -329,4 +327,4 @@ static struct platform_driver pwm_mediatek_driver = {
module_platform_driver(pwm_mediatek_driver);

MODULE_AUTHOR("John Crispin <[email protected]>");
-MODULE_LICENSE("GPL");
+MODULE_LICENSE("GPL v2");
--
2.17.1

2019-09-26 10:57:52

by Sam Shih

[permalink] [raw]
Subject: [PATCH v10 11/12] dt-bindings: pwm: update bindings for MT7629 SoC

From: Ryder Lee <[email protected]>

This updates bindings for MT7629 pwm controller.

Signed-off-by: Ryder Lee <[email protected]>
Signed-off-by: Sam Shih <[email protected]>
Reviewed-by: Rob Herring <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
Changes since v7:
- add a missed Reviewed-by tag back from v1:
https://patchwork.kernel.org/patch/10769381/
Changes since v1:
- add a Reviewed-by tag

---
Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 1 +
1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
index 975d7871830d..744deea8a256 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
@@ -6,6 +6,7 @@ Required properties:
- "mediatek,mt7622-pwm": found on mt7622 SoC.
- "mediatek,mt7623-pwm": found on mt7623 SoC.
- "mediatek,mt7628-pwm": found on mt7628 SoC.
+ - "mediatek,mt7629-pwm": found on mt7629 SoC.
- reg: physical base address and length of the controller's registers.
- #pwm-cells: must be 2. See pwm.txt in this directory for a description of
the cell format.
--
2.17.1