2019-11-04 16:19:44

by Chuhong Yuan

Subject: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove

The remove misses to disable and unprepare jzdma->clk.
Add a call to clk_disable_unprepare to fix it.

Signed-off-by: Chuhong Yuan <[email protected]>
---
drivers/dma/dma-jz4780.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
index cafb1cc065bb..66ab76b9520f 100644
--- a/drivers/dma/dma-jz4780.c
+++ b/drivers/dma/dma-jz4780.c
@@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct platform_device *pdev)

of_dma_controller_free(pdev->dev.of_node);

+ clk_disable_unprepare(jzdma->clk);
free_irq(jzdma->irq, jzdma);

for (i = 0; i < jzdma->soc_data->nb_channels; i++)
--
2.23.0

2019-11-05 09:02:22

by Paul Cercueil

Subject: Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove

Hi,


Le mar., nov. 5, 2019 at 00:16, Chuhong Yuan <[email protected]> a
?crit :
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.
>
> Signed-off-by: Chuhong Yuan <[email protected]>

Acked-by: Paul Cercueil <[email protected]>

Thanks.


> ---
> drivers/dma/dma-jz4780.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/dma/dma-jz4780.c b/drivers/dma/dma-jz4780.c
> index cafb1cc065bb..66ab76b9520f 100644
> --- a/drivers/dma/dma-jz4780.c
> +++ b/drivers/dma/dma-jz4780.c
> @@ -987,6 +987,7 @@ static int jz4780_dma_remove(struct
> platform_device *pdev)
>
> of_dma_controller_free(pdev->dev.of_node);
>
> + clk_disable_unprepare(jzdma->clk);
> free_irq(jzdma->irq, jzdma);
>
> for (i = 0; i < jzdma->soc_data->nb_channels; i++)
> --
> 2.23.0
>

2019-11-08 03:58:11

by Vinod Koul

Subject: Re: [PATCH] dmaengine: dma-jz4780: add missed clk_disable_unprepare in remove

On 05-11-19, 00:16, Chuhong Yuan wrote:
> The remove misses to disable and unprepare jzdma->clk.
> Add a call to clk_disable_unprepare to fix it.

Applied, thanks

--
~Vinod