2019-12-11 19:01:10

by Matthias Brugger

Subject: [PATCH] soc: mediatek: cmdq: delete not used define

From: Matthias Brugger <[email protected]>

Define CMDQ_EOC_CMD was actually never used. Delete it.

Signed-off-by: Matthias Brugger <[email protected]>

---

drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 3c82de5f9417..1127c19c4e91 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -12,8 +12,6 @@
#define CMDQ_ARG_A_WRITE_MASK 0xffff
#define CMDQ_WRITE_ENABLE_MASK BIT(0)
#define CMDQ_EOC_IRQ_EN BIT(0)
-#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
- << 32 | CMDQ_EOC_IRQ_EN)

static void cmdq_client_timeout(struct timer_list *t)
{
--
2.24.0

2019-12-12 01:37:32

by Bibby Hsieh

Subject: Re: [PATCH] soc: mediatek: cmdq: delete not used define

On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:
> From: Matthias Brugger <[email protected]>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
> Signed-off-by: Matthias Brugger <[email protected]>

Thanks. :D

Reviewed-by: Bibby Hsieh <[email protected]>

>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {

2019-12-12 05:13:01

by CK Hu (胡俊光)

Subject: Re: [PATCH] soc: mediatek: cmdq: delete not used define

Hi, Matthias:

On Wed, 2019-12-11 at 19:59 +0100, [email protected] wrote:
> From: Matthias Brugger <[email protected]>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>

Reviewed-by: CK Hu <[email protected]>

> Signed-off-by: Matthias Brugger <[email protected]>
>
> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {

2019-12-14 22:09:35

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: cmdq: delete not used define

On 11/12/2019 19:59, [email protected] wrote:
> From: Matthias Brugger <[email protected]>
>
> Define CMDQ_EOC_CMD was actually never used. Delete it.
>
> Signed-off-by: Matthias Brugger <[email protected]>
>

Applied to v5.5-next/soc

Thanks for the reviews!

> ---
>
> drivers/soc/mediatek/mtk-cmdq-helper.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c b/drivers/soc/mediatek/mtk-cmdq-helper.c
> index 3c82de5f9417..1127c19c4e91 100644
> --- a/drivers/soc/mediatek/mtk-cmdq-helper.c
> +++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
> @@ -12,8 +12,6 @@
> #define CMDQ_ARG_A_WRITE_MASK 0xffff
> #define CMDQ_WRITE_ENABLE_MASK BIT(0)
> #define CMDQ_EOC_IRQ_EN BIT(0)
> -#define CMDQ_EOC_CMD ((u64)((CMDQ_CODE_EOC << CMDQ_OP_CODE_SHIFT)) \
> - << 32 | CMDQ_EOC_IRQ_EN)
>
> static void cmdq_client_timeout(struct timer_list *t)
> {
>