2020-01-01 08:23:57

by Julia Lawall

Subject: [PATCH 05/16] media: isif: constify copied structure

The isif_config_defaults structure is only copied into another
structure, so make it const.

The opportunity for this change was found using Coccinelle.

Signed-off-by: Julia Lawall <[email protected]>

---
drivers/media/platform/davinci/isif.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c
index b49378b18e5d..c98edb67cfb2 100644
--- a/drivers/media/platform/davinci/isif.c
+++ b/drivers/media/platform/davinci/isif.c
@@ -29,7 +29,7 @@
#include "ccdc_hw_device.h"

/* Defaults for module configuration parameters */
-static struct isif_config_params_raw isif_config_defaults = {
+static const struct isif_config_params_raw isif_config_defaults = {
.linearize = {
.en = 0,
.corr_shft = ISIF_NO_SHIFT,

2020-01-09 07:14:49

by Lad, Prabhakar

Subject: Re: [PATCH 05/16] media: isif: constify copied structure

On Wed, Jan 1, 2020 at 8:20 AM Julia Lawall <[email protected]> wrote:
>
> The isif_config_defaults structure is only copied into another
> structure, so make it const.
>
> The opportunity for this change was found using Coccinelle.
>
> Signed-off-by: Julia Lawall <[email protected]>
>

Acked-by: Lad Prabhakar <[email protected]>

Cheers,
--Prabhakar Lad

> ---
> drivers/media/platform/davinci/isif.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/davinci/isif.c b/drivers/media/platform/davinci/isif.c
> index b49378b18e5d..c98edb67cfb2 100644
> --- a/drivers/media/platform/davinci/isif.c
> +++ b/drivers/media/platform/davinci/isif.c
> @@ -29,7 +29,7 @@
> #include "ccdc_hw_device.h"
>
> /* Defaults for module configuration parameters */
> -static struct isif_config_params_raw isif_config_defaults = {
> +static const struct isif_config_params_raw isif_config_defaults = {
> .linearize = {
> .en = 0,
> .corr_shft = ISIF_NO_SHIFT,
>