2020-01-21 05:57:03

by Alex Shi

Subject: [PATCH] trace/kprobe: remove MAX_KPROBE_CMDLINE_SIZE

This limitation are never lunched from introduce commit 970988e19eb0
("tracing/kprobe: Add kprobe_event= boot parameter")

Could we remove it if no intention to implement it?

Signed-off-by: Alex Shi <[email protected]>
Cc: Steven Rostedt <[email protected]>
Cc: Ingo Molnar <[email protected]>
Cc: [email protected]
---
kernel/trace/trace_kprobe.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
index 7f890262c8a3..eafa90d0f760 100644
--- a/kernel/trace/trace_kprobe.c
+++ b/kernel/trace/trace_kprobe.c
@@ -22,7 +22,6 @@

#define KPROBE_EVENT_SYSTEM "kprobes"
#define KRETPROBE_MAXACTIVE_MAX 4096
-#define MAX_KPROBE_CMDLINE_SIZE 1024

/* Kprobe early definition from command line */
static char kprobe_boot_events_buf[COMMAND_LINE_SIZE] __initdata;
--
1.8.3.1

2020-01-21 23:36:09

by Steven Rostedt

Subject: Re: [PATCH] trace/kprobe: remove MAX_KPROBE_CMDLINE_SIZE

Masami,

With your new bootconfig work, will you be utilizing
MAX_KPROBE_CMDLINE_SIZE, or should it be removed?

-- Steve


On Tue, 21 Jan 2020 13:54:35 +0800
Alex Shi <[email protected]> wrote:

> This limitation are never lunched from introduce commit 970988e19eb0
> ("tracing/kprobe: Add kprobe_event= boot parameter")
>
> Could we remove it if no intention to implement it?
>
> Signed-off-by: Alex Shi <[email protected]>
> Cc: Steven Rostedt <[email protected]>
> Cc: Ingo Molnar <[email protected]>
> Cc: [email protected]
> ---
> kernel/trace/trace_kprobe.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index 7f890262c8a3..eafa90d0f760 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -22,7 +22,6 @@
>
> #define KPROBE_EVENT_SYSTEM "kprobes"
> #define KRETPROBE_MAXACTIVE_MAX 4096
> -#define MAX_KPROBE_CMDLINE_SIZE 1024
>
> /* Kprobe early definition from command line */
> static char kprobe_boot_events_buf[COMMAND_LINE_SIZE] __initdata;

2020-01-22 04:20:39

by Masami Hiramatsu

Subject: Re: [PATCH] trace/kprobe: remove MAX_KPROBE_CMDLINE_SIZE

On Tue, 21 Jan 2020 18:34:38 -0500
Steven Rostedt <[email protected]> wrote:

> Masami,
>
> With your new bootconfig work, will you be utilizing
> MAX_KPROBE_CMDLINE_SIZE, or should it be removed?

Good catch! Yes, please remove it.
I think I have forgot to remove it when I switched
to COMMAND_LINE_SIZE while writing the code.

Acked-by: Masami Hiramatsu <[email protected]>

Thank you!

>
> -- Steve
>
>
> On Tue, 21 Jan 2020 13:54:35 +0800
> Alex Shi <[email protected]> wrote:
>
> > This limitation are never lunched from introduce commit 970988e19eb0
> > ("tracing/kprobe: Add kprobe_event= boot parameter")
> >
> > Could we remove it if no intention to implement it?
> >
> > Signed-off-by: Alex Shi <[email protected]>
> > Cc: Steven Rostedt <[email protected]>
> > Cc: Ingo Molnar <[email protected]>
> > Cc: [email protected]
> > ---
> > kernel/trace/trace_kprobe.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> > index 7f890262c8a3..eafa90d0f760 100644
> > --- a/kernel/trace/trace_kprobe.c
> > +++ b/kernel/trace/trace_kprobe.c
> > @@ -22,7 +22,6 @@
> >
> > #define KPROBE_EVENT_SYSTEM "kprobes"
> > #define KRETPROBE_MAXACTIVE_MAX 4096
> > -#define MAX_KPROBE_CMDLINE_SIZE 1024
> >
> > /* Kprobe early definition from command line */
> > static char kprobe_boot_events_buf[COMMAND_LINE_SIZE] __initdata;
>


--
Masami Hiramatsu <[email protected]>