2013-05-20 08:54:59

by Chen Gang

Subject: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

When randconfig with MMU for arm s5pv210 (and select all cpu type),
need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:

arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'


Signed-off-by: Chen Gang <[email protected]>
---
arch/arm/plat-samsung/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index f8ed2de..1d38541 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -483,6 +483,7 @@ config S5P_PM

config S5P_SLEEP
bool
+ select ARM_CPU_SUSPEND
help
Internal config node to apply common S5P sleep management code.
Can be selected by S5P and newer SoCs with similar sleep procedure.
--
1.7.7.6

2013-05-27 10:06:02

by Chen Gang

Subject: Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

Hello Maintainers:

Please help check this patch whether OK, when you have time.


Thanks.

On 05/20/2013 04:54 PM, Chen Gang wrote:
>
> When randconfig with MMU for arm s5pv210 (and select all cpu type),
> need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
>
> arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
> arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'
>
>
> Signed-off-by: Chen Gang <[email protected]>
> ---
> arch/arm/plat-samsung/Kconfig | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
> index f8ed2de..1d38541 100644
> --- a/arch/arm/plat-samsung/Kconfig
> +++ b/arch/arm/plat-samsung/Kconfig
> @@ -483,6 +483,7 @@ config S5P_PM
>
> config S5P_SLEEP
> bool
> + select ARM_CPU_SUSPEND
> help
> Internal config node to apply common S5P sleep management code.
> Can be selected by S5P and newer SoCs with similar sleep procedure.
>


--
Chen Gang

Asianux Corporation

2013-05-27 10:12:18

by Kukjin Kim

Subject: RE: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

Chen Gang wrote:
>
> Hello Maintainers:
>
Hi,

> Please help check this patch whether OK, when you have time.
>
>
> Thanks.
>
> On 05/20/2013 04:54 PM, Chen Gang wrote:
> >
> > When randconfig with MMU for arm s5pv210 (and select all cpu type),
> > need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:
> >
> > arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
> > arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to
> `cpu_resume'
> >
> >
> > Signed-off-by: Chen Gang <[email protected]>
> > ---
> > arch/arm/plat-samsung/Kconfig | 1 +
> > 1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-
> samsung/Kconfig
> > index f8ed2de..1d38541 100644
> > --- a/arch/arm/plat-samsung/Kconfig
> > +++ b/arch/arm/plat-samsung/Kconfig
> > @@ -483,6 +483,7 @@ config S5P_PM
> >
> > config S5P_SLEEP
> > bool
> > + select ARM_CPU_SUSPEND

Probably,

+ select ARM_CPU_SUSPEND if PM ?

selecting the S5P_SLEEP depends on PM though...

- Kukjin

2013-05-27 10:50:47

by Chen Gang

Subject: Re: [PATCH] ARM: S5PV210: dependency issue, S5P_SLEEP is depend on ARM_CPU_SUSPEND

On 05/27/2013 06:12 PM, Kukjin Kim wrote:
>>> config S5P_SLEEP
>>> > > bool
>>> > > + select ARM_CPU_SUSPEND
> Probably,
>
> + select ARM_CPU_SUSPEND if PM ?
>
> selecting the S5P_SLEEP depends on PM though...

After reference another platform, they are really all "select
ARM_CPU_SUSPEND if PM", we'd really better to follow by to let readers
easy understanding.

I will send patch v2.


Thanks.
--
Chen Gang

Asianux Corporation

2013-05-27 10:58:29

by Chen Gang

Subject: [PATCH v2] arch: arm: plat-samsung: dependency, S5P_SLEEP depends on ARM_CPU_SUSPEND

When randconfig with MMU for arm s5pv210 (and select all cpu type),
need let S5P_SLEEP depend on ARM_CPU_SUSPEND, or will cause issue below:

arch/arm/plat-samsung/built-in.o: In function `s3c_cpu_resume':
arch/arm/plat-samsung/s5p-sleep.S:83: undefined reference to `cpu_resume'


Signed-off-by: Chen Gang <[email protected]>
---
arch/arm/plat-samsung/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index f8ed2de..b388d93 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -483,6 +483,7 @@ config S5P_PM

config S5P_SLEEP
bool
+ select ARM_CPU_SUSPEND if PM
help
Internal config node to apply common S5P sleep management code.
Can be selected by S5P and newer SoCs with similar sleep procedure.
--
1.7.7.6