2020-03-20 03:16:50

by Xiaoming Ni

[permalink] [raw]
Subject: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

mtdblock_flush()
-->write_cached_data()
--->erase_write()
mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed

Because mtdblock_flush() always returns 0,
even if write_cached_data() fails and data is not written to the device,
syscall_write() still returns success

Signed-off-by: Xiaoming Ni <[email protected]>
---
drivers/mtd/mtdblock.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/mtd/mtdblock.c b/drivers/mtd/mtdblock.c
index c06b532..078e0f6 100644
--- a/drivers/mtd/mtdblock.c
+++ b/drivers/mtd/mtdblock.c
@@ -294,12 +294,13 @@ static void mtdblock_release(struct mtd_blktrans_dev *mbd)
static int mtdblock_flush(struct mtd_blktrans_dev *dev)
{
struct mtdblk_dev *mtdblk = container_of(dev, struct mtdblk_dev, mbd);
+ int ret;

mutex_lock(&mtdblk->cache_mutex);
- write_cached_data(mtdblk);
+ ret = write_cached_data(mtdblk);
mutex_unlock(&mtdblk->cache_mutex);
mtd_sync(dev->mtd);
- return 0;
+ return ret;
}

static void mtdblock_add_mtd(struct mtd_blktrans_ops *tr, struct mtd_info *mtd)
--
1.8.5.6


2020-03-24 22:07:15

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

On Fri, 2020-03-20 at 03:15:11 UTC, Xiaoming Ni wrote:
> mtdblock_flush()
> -->write_cached_data()
> --->erase_write()
> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>
> Because mtdblock_flush() always returns 0,
> even if write_cached_data() fails and data is not written to the device,
> syscall_write() still returns success
>
> Signed-off-by: Xiaoming Ni <[email protected]>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next, thanks.

Miquel

2020-03-24 22:09:39

by Miquel Raynal

[permalink] [raw]
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

Hi Xiaoming,

Xiaoming Ni <[email protected]> wrote on Fri, 20 Mar 2020 11:15:11
+0800:

> mtdblock_flush()
> -->write_cached_data()
> --->erase_write()
> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>
> Because mtdblock_flush() always returns 0,
> even if write_cached_data() fails and data is not written to the device,
> syscall_write() still returns success

I reworded a bit the commit log and also added a ' ' after 'mtd:' in
the title when applying.

Thanks,
Miquèl

2020-03-25 07:55:19

by Xiaoming Ni

[permalink] [raw]
Subject: Re: [PATCH] mtd:Fix issue where write_cached_data() fails but write() still returns success

On 2020/3/25 6:06, Miquel Raynal wrote:
> Hi Xiaoming,
>
> Xiaoming Ni <[email protected]> wrote on Fri, 20 Mar 2020 11:15:11
> +0800:
>
>> mtdblock_flush()
>> -->write_cached_data()
>> --->erase_write()
>> mtdblock: erase of region [0x40000, 0x20000] on "xxx" failed
>>
>> Because mtdblock_flush() always returns 0,
>> even if write_cached_data() fails and data is not written to the device,
>> syscall_write() still returns success
>
> I reworded a bit the commit log and also added a ' ' after 'mtd:' in
> the title when applying.
>
> Thanks,
> Miquèl

Your revised commit log is more accurate and clearer, thanks for your
correction
Thanks.
Xiaoming Ni