2020-03-30 08:10:07

by Ding Xiang

Subject: [PATCH] pinctrl: nomadik:remove unneeded variable

ret is unneeded, just return 0.

Signed-off-by: Ding Xiang <[email protected]>
---
drivers/pinctrl/nomadik/pinctrl-nomadik.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/pinctrl/nomadik/pinctrl-nomadik.c b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
index 95f864d..4c56483 100644
--- a/drivers/pinctrl/nomadik/pinctrl-nomadik.c
+++ b/drivers/pinctrl/nomadik/pinctrl-nomadik.c
@@ -1340,8 +1340,6 @@ struct nmk_cfg_param {

static int nmk_dt_pin_config(int index, int val, unsigned long *config)
{
- int ret = 0;
-
if (nmk_cfg_params[index].choice == NULL)
*config = nmk_cfg_params[index].config;
else {
@@ -1351,7 +1349,7 @@ static int nmk_dt_pin_config(int index, int val, unsigned long *config)
nmk_cfg_params[index].choice[val];
}
}
- return ret;
+ return 0;
}

static const char *nmk_find_pin_name(struct pinctrl_dev *pctldev, const char *pin_name)
--
1.9.1

2020-04-16 07:59:05

by Linus Walleij

Subject: Re: [PATCH] pinctrl: nomadik:remove unneeded variable

On Mon, Mar 30, 2020 at 9:59 AM Ding Xiang
<[email protected]> wrote:

> ret is unneeded, just return 0.
>
> Signed-off-by: Ding Xiang <[email protected]>

Patch applied.

Yours,
Linus Walleij