2020-04-20 18:23:41

by Souptick Joarder

Subject: [PATCH] video/fbdev/riva: Remove dead code

These are dead code since 3.15. These can be removed forever if no
plan to use it further.

Signed-off-by: Souptick Joarder <[email protected]>
---
drivers/video/fbdev/riva/riva_hw.c | 18 ------------------
1 file changed, 18 deletions(-)

diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
index 0601c13..08c9ee4 100644
--- a/drivers/video/fbdev/riva/riva_hw.c
+++ b/drivers/video/fbdev/riva/riva_hw.c
@@ -1343,24 +1343,6 @@ static char nv3_get_param(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_ar
/*
* Load fixed function state and pre-calculated/stored state.
*/
-#if 0
-#define LOAD_FIXED_STATE(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
- chip->dev[tbl##Table##dev[i][0]] = tbl##Table##dev[i][1]
-#define LOAD_FIXED_STATE_8BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_8BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_8BPP[i][0]] = tbl##Table##dev##_8BPP[i][1]
-#define LOAD_FIXED_STATE_15BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_15BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_15BPP[i][0]] = tbl##Table##dev##_15BPP[i][1]
-#define LOAD_FIXED_STATE_16BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_16BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_16BPP[i][0]] = tbl##Table##dev##_16BPP[i][1]
-#define LOAD_FIXED_STATE_32BPP(tbl,dev) \
- for (i = 0; i < sizeof(tbl##Table##dev##_32BPP)/8; i++) \
- chip->dev[tbl##Table##dev##_32BPP[i][0]] = tbl##Table##dev##_32BPP[i][1]
-#endif
-
#define LOAD_FIXED_STATE(tbl,dev) \
for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
NV_WR32(&chip->dev[tbl##Table##dev[i][0]], 0, tbl##Table##dev[i][1])
--
1.9.1

2020-04-25 15:13:04

by Sam Ravnborg

Subject: Re: [PATCH] video/fbdev/riva: Remove dead code

Hi Souptick
On Mon, Apr 20, 2020 at 11:57:24PM +0530, Souptick Joarder wrote:
> These are dead code since 3.15. These can be removed forever if no
> plan to use it further.
>
> Signed-off-by: Souptick Joarder <[email protected]>

Thanks. Patch applied to drm-misc-next.
It will appear in mianline kernel in next merge window.

Sam


> ---
> drivers/video/fbdev/riva/riva_hw.c | 18 ------------------
> 1 file changed, 18 deletions(-)
>
> diff --git a/drivers/video/fbdev/riva/riva_hw.c b/drivers/video/fbdev/riva/riva_hw.c
> index 0601c13..08c9ee4 100644
> --- a/drivers/video/fbdev/riva/riva_hw.c
> +++ b/drivers/video/fbdev/riva/riva_hw.c
> @@ -1343,24 +1343,6 @@ static char nv3_get_param(nv3_fifo_info *res_info, nv3_sim_state * state, nv3_ar
> /*
> * Load fixed function state and pre-calculated/stored state.
> */
> -#if 0
> -#define LOAD_FIXED_STATE(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
> - chip->dev[tbl##Table##dev[i][0]] = tbl##Table##dev[i][1]
> -#define LOAD_FIXED_STATE_8BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_8BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_8BPP[i][0]] = tbl##Table##dev##_8BPP[i][1]
> -#define LOAD_FIXED_STATE_15BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_15BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_15BPP[i][0]] = tbl##Table##dev##_15BPP[i][1]
> -#define LOAD_FIXED_STATE_16BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_16BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_16BPP[i][0]] = tbl##Table##dev##_16BPP[i][1]
> -#define LOAD_FIXED_STATE_32BPP(tbl,dev) \
> - for (i = 0; i < sizeof(tbl##Table##dev##_32BPP)/8; i++) \
> - chip->dev[tbl##Table##dev##_32BPP[i][0]] = tbl##Table##dev##_32BPP[i][1]
> -#endif
> -
> #define LOAD_FIXED_STATE(tbl,dev) \
> for (i = 0; i < sizeof(tbl##Table##dev)/8; i++) \
> NV_WR32(&chip->dev[tbl##Table##dev[i][0]], 0, tbl##Table##dev[i][1])
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel