2020-04-29 06:38:09

by Zhangshaokun

[permalink] [raw]
Subject: [PATCH RESEND] perf tools: Fix function name in comment

get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
fix the name in comment.

Cc: Arnaldo Carvalho de Melo <[email protected]>
CC: Andi Kleen <[email protected]>
Signed-off-by: Shaokun Zhang <[email protected]>
---
tools/perf/pmu-events/pmu-events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
index 53e76d5d5b37..c8f306b572f4 100644
--- a/tools/perf/pmu-events/pmu-events.h
+++ b/tools/perf/pmu-events/pmu-events.h
@@ -26,7 +26,7 @@ struct pmu_event {
* Map a CPU to its table of PMU events. The CPU is identified by the
* cpuid field, which is an arch-specific identifier for the CPU.
* The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
- * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
+ * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
*
* The cpuid can contain any character other than the comma.
*/
--
2.7.4


2020-04-29 14:37:20

by Arnaldo Carvalho de Melo

[permalink] [raw]
Subject: Re: [PATCH RESEND] perf tools: Fix function name in comment

Em Wed, Apr 29, 2020 at 02:33:12PM +0800, Shaokun Zhang escreveu:
> get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
> fix the name in comment.
>
> Cc: Arnaldo Carvalho de Melo <[email protected]>
> CC: Andi Kleen <[email protected]>
> Signed-off-by: Shaokun Zhang <[email protected]>
> ---
> tools/perf/pmu-events/pmu-events.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
> index 53e76d5d5b37..c8f306b572f4 100644
> --- a/tools/perf/pmu-events/pmu-events.h
> +++ b/tools/perf/pmu-events/pmu-events.h
> @@ -26,7 +26,7 @@ struct pmu_event {
> * Map a CPU to its table of PMU events. The CPU is identified by the
> * cpuid field, which is an arch-specific identifier for the CPU.
> * The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
> - * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
> + * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
> *
> * The cpuid can contain any character other than the comma.
> */

Thanks, applied.

- Arnaldo

Subject: [tip: perf/core] perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr()

The following commit has been merged into the perf/core branch of tip:

Commit-ID: 454a8be0cff954f18729964317b40ef2c3031364
Gitweb: https://git.kernel.org/tip/454a8be0cff954f18729964317b40ef2c3031364
Author: Shaokun Zhang <[email protected]>
AuthorDate: Wed, 29 Apr 2020 14:33:12 +08:00
Committer: Arnaldo Carvalho de Melo <[email protected]>
CommitterDate: Thu, 30 Apr 2020 10:48:33 -03:00

perf pmu: Fix function name in comment, its get_cpuid_str(), not get_cpustr()

get_cpuid_str() is used in tools/perf/arch/xxx/util/header.c,
fix the name in comment.

Signed-off-by: Shaokun Zhang <[email protected]>
Cc: Andi Kleen <[email protected]>
Link: http://lore.kernel.org/lkml/[email protected]
Signed-off-by: Arnaldo Carvalho de Melo <[email protected]>
---
tools/perf/pmu-events/pmu-events.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/pmu-events/pmu-events.h b/tools/perf/pmu-events/pmu-events.h
index 53e76d5..c8f306b 100644
--- a/tools/perf/pmu-events/pmu-events.h
+++ b/tools/perf/pmu-events/pmu-events.h
@@ -26,7 +26,7 @@ struct pmu_event {
* Map a CPU to its table of PMU events. The CPU is identified by the
* cpuid field, which is an arch-specific identifier for the CPU.
* The identifier specified in tools/perf/pmu-events/arch/xxx/mapfile
- * must match the get_cpustr() in tools/perf/arch/xxx/util/header.c)
+ * must match the get_cpuid_str() in tools/perf/arch/xxx/util/header.c)
*
* The cpuid can contain any character other than the comma.
*/