2020-04-30 12:09:28

by Zou Wei

Subject: [PATCH -next] drm/udl: Make udl_handle_damage static

Fix the following sparse warning:

drivers/gpu/drm/udl/udl_modeset.c:269:5: warning: symbol 'udl_handle_damage'
was not declared. Should it be static?

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Zou Wei <[email protected]>
---
drivers/gpu/drm/udl/udl_modeset.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
index 99518a8..fef43f4 100644
--- a/drivers/gpu/drm/udl/udl_modeset.c
+++ b/drivers/gpu/drm/udl/udl_modeset.c
@@ -266,8 +266,8 @@ static int udl_aligned_damage_clip(struct drm_rect *clip, int x, int y,
return 0;
}

-int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
- int width, int height)
+static int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
+ int width, int height)
{
struct drm_device *dev = fb->dev;
struct dma_buf_attachment *import_attach = fb->obj[0]->import_attach;
--
2.6.2

2020-05-07 01:34:39

by Sam Ravnborg

Subject: Re: [PATCH -next] drm/udl: Make udl_handle_damage static

Hi Zou Wei.

On Thu, Apr 30, 2020 at 08:13:17PM +0800, Zou Wei wrote:
> Fix the following sparse warning:
>
> drivers/gpu/drm/udl/udl_modeset.c:269:5: warning: symbol 'udl_handle_damage'
> was not declared. Should it be static?
>
> Reported-by: Hulk Robot <[email protected]>
> Signed-off-by: Zou Wei <[email protected]>

Thanks, applied to drm-misc-next.

Sam

> ---
> drivers/gpu/drm/udl/udl_modeset.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/udl/udl_modeset.c b/drivers/gpu/drm/udl/udl_modeset.c
> index 99518a8..fef43f4 100644
> --- a/drivers/gpu/drm/udl/udl_modeset.c
> +++ b/drivers/gpu/drm/udl/udl_modeset.c
> @@ -266,8 +266,8 @@ static int udl_aligned_damage_clip(struct drm_rect *clip, int x, int y,
> return 0;
> }
>
> -int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
> - int width, int height)
> +static int udl_handle_damage(struct drm_framebuffer *fb, int x, int y,
> + int width, int height)
> {
> struct drm_device *dev = fb->dev;
> struct dma_buf_attachment *import_attach = fb->obj[0]->import_attach;
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel