2020-04-06 07:50:06

by Muchun Song

Subject: [PATCH] sched/fair: add __init to sched_init_granularity functions

Function sched_init_granularity() is only called from __init
functions, so mark it __init as well.

Signed-off-by: Muchun Song <[email protected]>
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 1141c7e77564d..6f05843c76d7d 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -191,7 +191,7 @@ static void update_sysctl(void)
#undef SET_SYSCTL
}

-void sched_init_granularity(void)
+void __init sched_init_granularity(void)
{
update_sysctl();
}
--
2.11.0

2020-04-13 15:37:24

by Muchun Song

Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity functions

On Mon, Apr 6, 2020 at 3:48 PM Muchun Song <[email protected]> wrote:
>
> Function sched_init_granularity() is only called from __init
> functions, so mark it __init as well.
>
> Signed-off-by: Muchun Song <[email protected]>
> ---
> kernel/sched/fair.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 1141c7e77564d..6f05843c76d7d 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -191,7 +191,7 @@ static void update_sysctl(void)
> #undef SET_SYSCTL
> }
>
> -void sched_init_granularity(void)
> +void __init sched_init_granularity(void)
> {
> update_sysctl();
> }
> --
> 2.11.0
>

Ping guys. Any suggestions?

--
Yours,
Muchun

2020-04-14 20:43:14

by Steven Rostedt

Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity functions

On Mon, 13 Apr 2020 23:07:03 +0800
宋牧春 <[email protected]> wrote:

> > -void sched_init_granularity(void)
> > +void __init sched_init_granularity(void)
> > {
> > update_sysctl();
> > }
> > --
> > 2.11.0
> >
>
> Ping guys. Any suggestions?

Seems fine, but not that big of an issue as it's a very small function.

ffffffff81136880 <sched_init_granularity>:
ffffffff81136880: e8 7b b3 ac 00 callq ffffffff81c01c00 <__fentry__>
ffffffff81136881: R_X86_64_PLT32 __fentry__-0x4
ffffffff81136885: e9 86 86 ff ff jmpq ffffffff8112ef10 <update_sysctl>
ffffffff8113688a: 66 0f 1f 44 00 00 nopw 0x0(%rax,%rax,1)


But anyway, it can save 16 bytes of memory in the running kernel.

Reviewed-by: Steven Rostedt (VMware) <[email protected]>

-- Steve

2020-05-01 18:26:34

by tip-bot2 for Eric Biggers

Subject: [tip: sched/core] sched/fair: Mark sched_init_granularity __init

The following commit has been merged into the sched/core branch of tip:

Commit-ID: f38f12d1e0811c0ee59260b2bdadedf99e16c4af
Gitweb: https://git.kernel.org/tip/f38f12d1e0811c0ee59260b2bdadedf99e16c4af
Author: Muchun Song <[email protected]>
AuthorDate: Mon, 06 Apr 2020 15:47:50 +08:00
Committer: Peter Zijlstra <[email protected]>
CommitterDate: Thu, 30 Apr 2020 20:14:41 +02:00

sched/fair: Mark sched_init_granularity __init

Function sched_init_granularity() is only called from __init
functions, so mark it __init as well.

Signed-off-by: Muchun Song <[email protected]>
Signed-off-by: Peter Zijlstra (Intel) <[email protected]>
Reviewed-by: Steven Rostedt (VMware) <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index fac5b2f..cd7fd7e 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -191,7 +191,7 @@ static void update_sysctl(void)
#undef SET_SYSCTL
}

-void sched_init_granularity(void)
+void __init sched_init_granularity(void)
{
update_sysctl();
}