2020-05-18 12:24:43

by Maulik Shah

Subject: [PATCH] arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

Few PDC interrupts do not map to respective parent GIC interrupt.
Fix this by correcting the pdc interrupt map.

Fixes: 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
Cc: [email protected]
Signed-off-by: Maulik Shah <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index f1280e0..f6b4ee8 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2308,8 +2308,7 @@
pdc: interrupt-controller@b220000 {
compatible = "qcom,sc7180-pdc", "qcom,pdc";
reg = <0 0x0b220000 0 0x30000>;
- qcom,pdc-ranges = <0 480 15>, <17 497 98>,
- <119 634 4>, <124 639 1>;
+ qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;
#interrupt-cells = <2>;
interrupt-parent = <&intc>;
interrupt-controller;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

2020-05-19 03:12:44

by Bjorn Andersson

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

On Mon 18 May 05:20 PDT 2020, Maulik Shah wrote:

> Few PDC interrupts do not map to respective parent GIC interrupt.
> Fix this by correcting the pdc interrupt map.
>
> Fixes: 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
> Cc: [email protected]
> Signed-off-by: Maulik Shah <[email protected]>

Applied

Thanks,
Bjorn

> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index f1280e0..f6b4ee8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2308,8 +2308,7 @@
> pdc: interrupt-controller@b220000 {
> compatible = "qcom,sc7180-pdc", "qcom,pdc";
> reg = <0 0x0b220000 0 0x30000>;
> - qcom,pdc-ranges = <0 480 15>, <17 497 98>,
> - <119 634 4>, <124 639 1>;
> + qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;
> #interrupt-cells = <2>;
> interrupt-parent = <&intc>;
> interrupt-controller;
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation

2020-05-21 00:41:52

by Stephen Boyd

Subject: Re: [PATCH] arm64: dts: qcom: sc7180: Correct the pdc interrupt ranges

Quoting Maulik Shah (2020-05-18 05:20:02)
> Few PDC interrupts do not map to respective parent GIC interrupt.
> Fix this by correcting the pdc interrupt map.
>
> Fixes: 22f185ee81d2 ("arm64: dts: qcom: sc7180: Add pdc interrupt controller")
> Cc: [email protected]
> Signed-off-by: Maulik Shah <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7180.dtsi | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index f1280e0..f6b4ee8 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2308,8 +2308,7 @@
> pdc: interrupt-controller@b220000 {
> compatible = "qcom,sc7180-pdc", "qcom,pdc";
> reg = <0 0x0b220000 0 0x30000>;
> - qcom,pdc-ranges = <0 480 15>, <17 497 98>,
> - <119 634 4>, <124 639 1>;
> + qcom,pdc-ranges = <0 480 94>, <94 609 31>, <125 63 1>;

This is a sign that we shouldn't put this information in DT. It was
wrong once so who knows if it will be wrong again. We don't have an
automated way to check this like we can check other properties. And the
information isn't something that is changed by firmware or the OS
loader. It is static data about the internals of the PDC device and how
it maps PDC pins to GIC SPI lines. We are probably better off just
setting up these ranges in the driver vs. relying on DT authors to get
it right.