2020-05-21 06:36:45

by Xu Wang

Subject: [PATCH] scrpits: Remove unneeded assignment parentheses

Remove unneeded assignment parentheses.

Signed-off-by: Xu Wang <[email protected]>
---
scripts/extract-cert.c | 2 +-
scripts/sign-file.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/scripts/extract-cert.c b/scripts/extract-cert.c
index b071bf476fea..8005911926b8 100644
--- a/scripts/extract-cert.c
+++ b/scripts/extract-cert.c
@@ -61,7 +61,7 @@ static void drain_openssl_errors(void)

#define ERR(cond, fmt, ...) \
do { \
- bool __cond = (cond); \
+ bool __cond = cond; \
display_openssl_errors(__LINE__); \
if (__cond) { \
err(1, fmt, ## __VA_ARGS__); \
diff --git a/scripts/sign-file.c b/scripts/sign-file.c
index fbd34b8e8f57..9ea08b07a0aa 100644
--- a/scripts/sign-file.c
+++ b/scripts/sign-file.c
@@ -104,7 +104,7 @@ static void drain_openssl_errors(void)

#define ERR(cond, fmt, ...) \
do { \
- bool __cond = (cond); \
+ bool __cond = cond; \
display_openssl_errors(__LINE__); \
if (__cond) { \
err(1, fmt, ## __VA_ARGS__); \
--
2.17.1

2020-05-21 14:15:48

by James Bottomley

Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses

On Thu, 2020-05-21 at 06:32 +0000, Xu Wang wrote:
> Remove unneeded assignment parentheses.

I really don't think this is a good idea. Best practice for macros is
to parenthesize every argument even if there are technically some cases
where it's unnecessary because the problems in the majority cases are
huge and unexpected.

James

> Signed-off-by: Xu Wang <[email protected]>
> ---
> scripts/extract-cert.c | 2 +-
> scripts/sign-file.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/extract-cert.c b/scripts/extract-cert.c
> index b071bf476fea..8005911926b8 100644
> --- a/scripts/extract-cert.c
> +++ b/scripts/extract-cert.c
> @@ -61,7 +61,7 @@ static void drain_openssl_errors(void)
>
> #define ERR(cond, fmt, ...) \
> do { \
> - bool __cond = (cond); \
> + bool __cond = cond; \
> display_openssl_errors(__LINE__); \
> if (__cond) { \
> err(1, fmt, ## __VA_ARGS__); \
> diff --git a/scripts/sign-file.c b/scripts/sign-file.c
> index fbd34b8e8f57..9ea08b07a0aa 100644
> --- a/scripts/sign-file.c
> +++ b/scripts/sign-file.c
> @@ -104,7 +104,7 @@ static void drain_openssl_errors(void)
>
> #define ERR(cond, fmt, ...) \
> do { \
> - bool __cond = (cond); \
> + bool __cond = cond; \
> display_openssl_errors(__LINE__); \
> if (__cond) { \
> err(1, fmt, ## __VA_ARGS__); \

2020-05-21 14:33:10

by David Howells

Subject: Re: [PATCH] scrpits: Remove unneeded assignment parentheses

James Bottomley <[email protected]> wrote:

> > Remove unneeded assignment parentheses.
>
> I really don't think this is a good idea. Best practice for macros is
> to parenthesize every argument even if there are technically some cases
> where it's unnecessary because the problems in the majority cases are
> huge and unexpected.

Yep.

David