2020-05-27 10:20:26

by Weiyi Lu

Subject: [PATCH v2] clk: mediatek: assign the initial value to clk_init_data of mtk_mux

When some new clock supports are introduced, e.g. [1]
it might lead to an error although it should be NULL because
clk_init_data is on the stack and it might have random values
if using without initialization.
Add the missing initial value to clk_init_data.

[1] https://android-review.googlesource.com/c/kernel/common/+/1278046

Fixes: a3ae549917f1 ("clk: mediatek: Add new clkmux register API")
Cc: <[email protected]>
Signed-off-by: Weiyi Lu <[email protected]>
Reviewed-by: Matthias Brugger <[email protected]>
---
drivers/clk/mediatek/clk-mux.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/mediatek/clk-mux.c b/drivers/clk/mediatek/clk-mux.c
index 76f9cd0..14e127e 100644
--- a/drivers/clk/mediatek/clk-mux.c
+++ b/drivers/clk/mediatek/clk-mux.c
@@ -160,7 +160,7 @@ struct clk *mtk_clk_register_mux(const struct mtk_mux *mux,
spinlock_t *lock)
{
struct mtk_clk_mux *clk_mux;
- struct clk_init_data init;
+ struct clk_init_data init = {};
struct clk *clk;

clk_mux = kzalloc(sizeof(*clk_mux), GFP_KERNEL);
--
1.8.1.1.dirty

2020-05-29 04:28:45

by Stephen Boyd

Subject: Re: [PATCH v2] clk: mediatek: assign the initial value to clk_init_data of mtk_mux

Quoting Weiyi Lu (2020-05-26 23:25:49)
> When some new clock supports are introduced, e.g. [1]
> it might lead to an error although it should be NULL because
> clk_init_data is on the stack and it might have random values
> if using without initialization.
> Add the missing initial value to clk_init_data.
>
> [1] https://android-review.googlesource.com/c/kernel/common/+/1278046
>
> Fixes: a3ae549917f1 ("clk: mediatek: Add new clkmux register API")
> Cc: <[email protected]>
> Signed-off-by: Weiyi Lu <[email protected]>
> Reviewed-by: Matthias Brugger <[email protected]>
> ---

Applied to clk-next