2020-09-17 09:23:03

by Xiaofei Tan

Subject: [PATCH] fbdev: mx3fb: remove unused variable 'irq'

Remove the variable 'irq' that is set but never used.

Signed-off-by: Xiaofei Tan <[email protected]>
---
drivers/video/fbdev/mx3fb.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
index 603731a..894617d 100644
--- a/drivers/video/fbdev/mx3fb.c
+++ b/drivers/video/fbdev/mx3fb.c
@@ -1428,7 +1428,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
struct device *dev = mx3fb->dev;
struct mx3fb_platform_data *mx3fb_pdata = dev_get_platdata(dev);
const char *name = mx3fb_pdata->name;
- unsigned int irq;
struct fb_info *fbi;
struct mx3fb_info *mx3fbi;
const struct fb_videomode *mode;
@@ -1441,7 +1440,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
}

ichan->client = mx3fb;
- irq = ichan->eof_irq;

if (ichan->dma_chan.chan_id != IDMAC_SDC_0)
return -EINVAL;
--
2.8.1

2020-09-24 20:14:28

by Sam Ravnborg

Subject: Re: [PATCH] fbdev: mx3fb: remove unused variable 'irq'

On Thu, Sep 17, 2020 at 05:19:20PM +0800, Xiaofei Tan wrote:
> Remove the variable 'irq' that is set but never used.
>
> Signed-off-by: Xiaofei Tan <[email protected]>

Thanks, applied to drm-misc-next.

Sam

> ---
> drivers/video/fbdev/mx3fb.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/mx3fb.c b/drivers/video/fbdev/mx3fb.c
> index 603731a..894617d 100644
> --- a/drivers/video/fbdev/mx3fb.c
> +++ b/drivers/video/fbdev/mx3fb.c
> @@ -1428,7 +1428,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
> struct device *dev = mx3fb->dev;
> struct mx3fb_platform_data *mx3fb_pdata = dev_get_platdata(dev);
> const char *name = mx3fb_pdata->name;
> - unsigned int irq;
> struct fb_info *fbi;
> struct mx3fb_info *mx3fbi;
> const struct fb_videomode *mode;
> @@ -1441,7 +1440,6 @@ static int init_fb_chan(struct mx3fb_data *mx3fb, struct idmac_channel *ichan)
> }
>
> ichan->client = mx3fb;
> - irq = ichan->eof_irq;
>
> if (ichan->dma_chan.chan_id != IDMAC_SDC_0)
> return -EINVAL;
> --
> 2.8.1