2020-10-02 20:02:28

by Matthew Rosato

Subject: [PATCH v2 2/5] s390/pci: track whether util_str is valid in the zpci_dev

We'll need to keep track of whether or not the byte string in util_str is
valid and thus needs to be passed to a vfio-pci passthrough device.

Signed-off-by: Matthew Rosato <[email protected]>
Acked-by: Niklas Schnelle <[email protected]>
Acked-by: Christian Borntraeger <[email protected]>
---
arch/s390/include/asm/pci.h | 3 ++-
arch/s390/pci/pci_clp.c | 1 +
2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/s390/include/asm/pci.h b/arch/s390/include/asm/pci.h
index 882e233..fa1fed4 100644
--- a/arch/s390/include/asm/pci.h
+++ b/arch/s390/include/asm/pci.h
@@ -132,7 +132,8 @@ struct zpci_dev {
u8 rid_available : 1;
u8 has_hp_slot : 1;
u8 is_physfn : 1;
- u8 reserved : 5;
+ u8 util_str_avail : 1;
+ u8 reserved : 4;
unsigned int devfn; /* DEVFN part of the RID*/

struct mutex lock;
diff --git a/arch/s390/pci/pci_clp.c b/arch/s390/pci/pci_clp.c
index 48bf316..322689b 100644
--- a/arch/s390/pci/pci_clp.c
+++ b/arch/s390/pci/pci_clp.c
@@ -168,6 +168,7 @@ static int clp_store_query_pci_fn(struct zpci_dev *zdev,
if (response->util_str_avail) {
memcpy(zdev->util_str, response->util_str,
sizeof(zdev->util_str));
+ zdev->util_str_avail = 1;
}
zdev->mio_capable = response->mio_addr_avail;
for (i = 0; i < PCI_STD_NUM_BARS; i++) {
--
1.8.3.1

2020-10-06 15:27:36

by Cornelia Huck

Subject: Re: [PATCH v2 2/5] s390/pci: track whether util_str is valid in the zpci_dev

On Fri, 2 Oct 2020 16:00:41 -0400
Matthew Rosato <[email protected]> wrote:

> We'll need to keep track of whether or not the byte string in util_str is
> valid and thus needs to be passed to a vfio-pci passthrough device.
>
> Signed-off-by: Matthew Rosato <[email protected]>
> Acked-by: Niklas Schnelle <[email protected]>
> Acked-by: Christian Borntraeger <[email protected]>
> ---
> arch/s390/include/asm/pci.h | 3 ++-
> arch/s390/pci/pci_clp.c | 1 +
> 2 files changed, 3 insertions(+), 1 deletion(-)

FWIW:

Acked-by: Cornelia Huck <[email protected]>