2020-12-18 07:50:32

by Zhaoyang Huang

Subject: [PATCH] driver: staging: count ashmem_range into SLAB_RECLAIMBLE

From: Zhaoyang Huang <[email protected]>

Add SLAB_RECLAIM_ACCOUNT to ashmem_range cache since it has registered
shrinker, which make memAvailable more presiced.

Signed-off-by: Zhaoyang Huang <[email protected]>
---
drivers/staging/android/ashmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
index 74d497d..b79301f 100644
--- a/drivers/staging/android/ashmem.c
+++ b/drivers/staging/android/ashmem.c
@@ -893,7 +893,7 @@ static int __init ashmem_init(void)

ashmem_range_cachep = kmem_cache_create("ashmem_range_cache",
sizeof(struct ashmem_range),
- 0, 0, NULL);
+ 0, SLAB_RECLAIM_ACCOUNT, NULL);
if (!ashmem_range_cachep) {
pr_err("failed to create slab cache\n");
goto out_free1;
--
1.9.1

2020-12-21 19:01:32

by Todd Kjos

Subject: Re: [PATCH] driver: staging: count ashmem_range into SLAB_RECLAIMBLE

+Hridya Valsaraju +Suren Baghdasaryan


On Thu, Dec 17, 2020 at 11:48 PM Huangzhaoyang <[email protected]> wrote:
>
> From: Zhaoyang Huang <[email protected]>
>
> Add SLAB_RECLAIM_ACCOUNT to ashmem_range cache since it has registered
> shrinker, which make memAvailable more presiced.
>
> Signed-off-by: Zhaoyang Huang <[email protected]>

Acked-by: Todd Kjos <[email protected]>

> ---
> drivers/staging/android/ashmem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/ashmem.c b/drivers/staging/android/ashmem.c
> index 74d497d..b79301f 100644
> --- a/drivers/staging/android/ashmem.c
> +++ b/drivers/staging/android/ashmem.c
> @@ -893,7 +893,7 @@ static int __init ashmem_init(void)
>
> ashmem_range_cachep = kmem_cache_create("ashmem_range_cache",
> sizeof(struct ashmem_range),
> - 0, 0, NULL);
> + 0, SLAB_RECLAIM_ACCOUNT, NULL);
> if (!ashmem_range_cachep) {
> pr_err("failed to create slab cache\n");
> goto out_free1;
> --
> 1.9.1
>