2021-01-03 21:43:00

by Jeff LaBundy

[permalink] [raw]
Subject: [PATCH 2/6] mfd: iqs62x: Remove unused bit mask

The register write that performed a mandatory soft reset during
probe was removed during development of the driver, however the
IQS62X_SYS_SETTINGS_SOFT_RESET bit mask was left behind. Remove
it to keep stray macros out of the driver.

Signed-off-by: Jeff LaBundy <[email protected]>
---
drivers/mfd/iqs62x.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/mfd/iqs62x.c b/drivers/mfd/iqs62x.c
index ec4c790..ff968dc 100644
--- a/drivers/mfd/iqs62x.c
+++ b/drivers/mfd/iqs62x.c
@@ -57,7 +57,6 @@
#define IQS620_TEMP_CAL_OFFS 0xC4

#define IQS62X_SYS_SETTINGS 0xD0
-#define IQS62X_SYS_SETTINGS_SOFT_RESET BIT(7)
#define IQS62X_SYS_SETTINGS_ACK_RESET BIT(6)
#define IQS62X_SYS_SETTINGS_EVENT_MODE BIT(5)
#define IQS62X_SYS_SETTINGS_CLK_DIV BIT(4)
--
2.7.4


2021-01-14 10:21:26

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH 2/6] mfd: iqs62x: Remove unused bit mask

On Sun, 03 Jan 2021, Jeff LaBundy wrote:

> The register write that performed a mandatory soft reset during
> probe was removed during development of the driver, however the
> IQS62X_SYS_SETTINGS_SOFT_RESET bit mask was left behind. Remove
> it to keep stray macros out of the driver.
>
> Signed-off-by: Jeff LaBundy <[email protected]>
> ---
> drivers/mfd/iqs62x.c | 1 -
> 1 file changed, 1 deletion(-)

For my own reference (apply this as-is to your sign-off block):

Acked-for-MFD-by: Lee Jones <[email protected]>

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog