2021-01-13 19:04:58

by Kuogee Hsieh

Subject: [PATCH v2 0/2] fix missing unplug interrupt problem

Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
Therefore irq_hpd handler should not issues either aux or sw reset
to avoid following unplug interrupt be cleared accidentally.

Kuogee Hsieh (2):
drm/msm/dp: return fail when both link lane and rate are 0 at dpcd
read
drm/msm/dp: unplug interrupt missed after irq_hpd handler

drivers/gpu/drm/msm/dp/dp_aux.c | 7 -------
drivers/gpu/drm/msm/dp/dp_catalog.c | 24 ++++++++++++++++++++++++
drivers/gpu/drm/msm/dp/dp_ctrl.c | 15 ++++++++++-----
drivers/gpu/drm/msm/dp/dp_display.c | 7 +++++++
drivers/gpu/drm/msm/dp/dp_panel.c | 12 +++++++++---
5 files changed, 50 insertions(+), 15 deletions(-)

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2021-01-13 20:29:38

by Stephen Boyd

Subject: Re: [PATCH v2 0/2] fix missing unplug interrupt problem

Quoting Kuogee Hsieh (2021-01-13 10:59:58)
> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
> Therefore irq_hpd handler should not issues either aux or sw reset
> to avoid following unplug interrupt be cleared accidentally.
>
> Kuogee Hsieh (2):
> drm/msm/dp: return fail when both link lane and rate are 0 at dpcd
> read
> drm/msm/dp: unplug interrupt missed after irq_hpd handler

It won't apply to the drm msm tree. Please rebase and resend.

2021-01-14 00:15:10

by Kuogee Hsieh

Subject: Re: [PATCH v2 0/2] fix missing unplug interrupt problem

On 2021-01-13 12:25, Stephen Boyd wrote:
> Quoting Kuogee Hsieh (2021-01-13 10:59:58)
>> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
>> Therefore irq_hpd handler should not issues either aux or sw reset
>> to avoid following unplug interrupt be cleared accidentally.
>>
>> Kuogee Hsieh (2):
>> drm/msm/dp: return fail when both link lane and rate are 0 at dpcd
>> read
>> drm/msm/dp: unplug interrupt missed after irq_hpd handler
>
> It won't apply to the drm msm tree. Please rebase and resend.
Both V1 two patches are picked by Rob already.
I will drop V2 patches.

2021-01-14 01:56:06

by Stephen Boyd

Subject: Re: [PATCH v2 0/2] fix missing unplug interrupt problem

Quoting [email protected] (2021-01-13 15:52:37)
> On 2021-01-13 12:25, Stephen Boyd wrote:
> > Quoting Kuogee Hsieh (2021-01-13 10:59:58)
> >> Both AUX_SW_RESET and DP_SW_RESET clear pending HPD interrupts.
> >> Therefore irq_hpd handler should not issues either aux or sw reset
> >> to avoid following unplug interrupt be cleared accidentally.
> >>
> >> Kuogee Hsieh (2):
> >> drm/msm/dp: return fail when both link lane and rate are 0 at dpcd
> >> read
> >> drm/msm/dp: unplug interrupt missed after irq_hpd handler
> >
> > It won't apply to the drm msm tree. Please rebase and resend.
> Both V1 two patches are picked by Rob already.
> I will drop V2 patches.

I only see the first patch, not the second one. Rob?