2021-01-19 07:38:58

by Ping-Ke Shih

[permalink] [raw]
Subject: Re: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison.

On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote:
> Fix the follow coccicheck warnings:
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
> WARNING: Comparison of 0/1 to bool variable.
>
> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
> WARNING: Comparison of 0/1 to bool variable.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Zhong <[email protected]>
> ---
> Changes in v2:
>   -Modified subject.
>

You forget to remove the period at the end of subject.
i.e.
"rtlwifi: rtl8192se: Simplify bool comparison"

---
Ping-Ke


2021-01-19 08:07:41

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] rtlwifi: rtl8192se: Simplify bool comparison.

Pkshih <[email protected]> writes:

> On Tue, 2021-01-19 at 14:32 +0800, Jiapeng Zhong wrote:
>> Fix the follow coccicheck warnings:
>>
>> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:2305:6-27:
>> WARNING: Comparison of 0/1 to bool variable.
>>
>> ./drivers/net/wireless/realtek/rtlwifi/rtl8192se/hw.c:1376:5-26:
>> WARNING: Comparison of 0/1 to bool variable.
>>
>> Reported-by: Abaci Robot <[email protected]>
>> Signed-off-by: Jiapeng Zhong <[email protected]>
>> ---
>> Changes in v2:
>>   -Modified subject.
>>
>
> You forget to remove the period at the end of subject.
> i.e.
> "rtlwifi: rtl8192se: Simplify bool comparison"

I can fix that during commit.

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches