2021-01-27 21:40:18

by Abaci Team

Subject: [PATCH] scsi: ufs: fix: NULL pointer dereference

Fix below warnings reported by coccicheck:
./drivers/scsi/ufs/ufshcd.c:8990:11-17: ERROR: hba is NULL but
dereferenced.

Reported-by: Abaci Robot <[email protected]>
Suggested-by: Yang Li <[email protected]>
Signed-off-by: Abaci Team <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index fb32d12..9319251 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -8990,7 +8990,6 @@ int ufshcd_system_resume(struct ufs_hba *hba)
ktime_t start = ktime_get();

if (!hba) {
- up(&hba->eh_sem);
return -EINVAL;
}

--
1.8.3.1

2021-01-27 21:42:24

by Avri Altman

Subject: RE: [PATCH] scsi: ufs: fix: NULL pointer dereference

>
> Fix below warnings reported by coccicheck:
> ./drivers/scsi/ufs/ufshcd.c:8990:11-17: ERROR: hba is NULL but
> dereferenced.
>
> Reported-by: Abaci Robot <[email protected]>
> Suggested-by: Yang Li <[email protected]>
> Signed-off-by: Abaci Team <[email protected]>
This was already fix in commit fb7afe24ba1b (scsi: ufs: Fix a possible NULL pointer issue)

> ---
> drivers/scsi/ufs/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index fb32d12..9319251 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -8990,7 +8990,6 @@ int ufshcd_system_resume(struct ufs_hba *hba)
> ktime_t start = ktime_get();
>
> if (!hba) {
> - up(&hba->eh_sem);
> return -EINVAL;
> }
>
> --
> 1.8.3.1