2021-01-27 21:49:40

by Abaci Team

Subject: [PATCH] zram: remove redundant NULL check

Fix below warnings reported by coccicheck:
./drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check before some
freeing functions is not needed.

Reported-by: Abaci Robot <[email protected]>
Suggested-by: Yang Li <[email protected]>
Signed-off-by: Abaci Team <[email protected]>
---
drivers/block/zram/zram_drv.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index e2933cb..92739b9 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -530,8 +530,7 @@ static ssize_t backing_dev_store(struct device *dev,

return len;
out:
- if (bitmap)
- kvfree(bitmap);
+ kvfree(bitmap);

if (bdev)
blkdev_put(bdev, FMODE_READ | FMODE_WRITE | FMODE_EXCL);
--
1.8.3.1

2021-01-28 00:06:43

by Jens Axboe

Subject: Re: [PATCH] zram: remove redundant NULL check

On 1/27/21 2:32 AM, Abaci Team wrote:
> Fix below warnings reported by coccicheck:
> ./drivers/block/zram/zram_drv.c:534:2-8: WARNING: NULL check before some
> freeing functions is not needed.

Already fixed/queued for 5.12:

https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.12/drivers&id=294ed6b9f00665acc22253044890257c5d9d18c1

--
Jens Axboe