2021-01-28 08:38:27

by Abaci Team

[permalink] [raw]
Subject: [PATCH] bpf: Simplify bool conversion

Fix the following coccicheck warning:
./tools/perf/builtin-script.c:2789:36-41: WARNING: conversion to bool
not needed here
./tools/perf/builtin-script.c:3237:48-53: WARNING: conversion to bool
not needed here

Reported-by: Abaci Robot <[email protected]>
Suggested-by: Yang Li <[email protected]>
Signed-off-by: Abaci Team <[email protected]>
---
tools/perf/builtin-script.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 42dad4a..3646a1c 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2786,7 +2786,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
break;
}
if (i == imax && strcmp(tok, "flags") == 0) {
- print_flags = change == REMOVE ? false : true;
+ print_flags = change != REMOVE;
continue;
}
if (i == imax) {
@@ -3234,7 +3234,7 @@ static char *get_script_path(const char *script_root, const char *suffix)

static bool is_top_script(const char *script_path)
{
- return ends_with(script_path, "top") == NULL ? false : true;
+ return ends_with(script_path, "top") != NULL;
}

static int has_required_arg(char *script_path)
--
1.8.3.1