2021-02-07 07:44:29

by Yang Li

Subject: [PATCH] selftests/x86/ldt_gdt: remove unneeded semicolon

Eliminate the following coccicheck warning:
./tools/testing/selftests/x86/ldt_gdt.c:610:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
tools/testing/selftests/x86/ldt_gdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/x86/ldt_gdt.c b/tools/testing/selftests/x86/ldt_gdt.c
index 1aef72d..3a29346 100644
--- a/tools/testing/selftests/x86/ldt_gdt.c
+++ b/tools/testing/selftests/x86/ldt_gdt.c
@@ -607,7 +607,7 @@ static void do_multicpu_tests(void)

failures++;
asm volatile ("mov %0, %%ss" : : "rm" (orig_ss));
- };
+ }

ftx = 100; /* Kill the thread. */
syscall(SYS_futex, &ftx, FUTEX_WAKE, 0, NULL, NULL, 0);
--
1.8.3.1

2021-02-08 23:37:52

by Shuah Khan

Subject: Re: [PATCH] selftests/x86/ldt_gdt: remove unneeded semicolon

On 2/7/21 12:42 AM, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/x86/ldt_gdt.c:610:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---
> tools/testing/selftests/x86/ldt_gdt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/x86/ldt_gdt.c b/tools/testing/selftests/x86/ldt_gdt.c
> index 1aef72d..3a29346 100644
> --- a/tools/testing/selftests/x86/ldt_gdt.c
> +++ b/tools/testing/selftests/x86/ldt_gdt.c
> @@ -607,7 +607,7 @@ static void do_multicpu_tests(void)
>
> failures++;
> asm volatile ("mov %0, %%ss" : : "rm" (orig_ss));
> - };
> + }
>
> ftx = 100; /* Kill the thread. */
> syscall(SYS_futex, &ftx, FUTEX_WAKE, 0, NULL, NULL, 0);
>

Thank you. Now applied to linux-kselftest next for 5.12-rc1

thanks,
-- Shuah