2021-02-07 09:11:49

by Yang Li

Subject: [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open

Eliminate the following coccicheck warning:
./drivers/platform/chrome/wilco_ec/telemetry.c:259:1-17: WARNING:
telem_fops: .read() and .write() have stream semantic; safe to change
nonseekable_open -> stream_open.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/platform/chrome/wilco_ec/telemetry.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/chrome/wilco_ec/telemetry.c b/drivers/platform/chrome/wilco_ec/telemetry.c
index e06d96f..60da7a2 100644
--- a/drivers/platform/chrome/wilco_ec/telemetry.c
+++ b/drivers/platform/chrome/wilco_ec/telemetry.c
@@ -256,7 +256,7 @@ static int telem_open(struct inode *inode, struct file *filp)
sess_data->dev_data = dev_data;
sess_data->has_msg = false;

- nonseekable_open(inode, filp);
+ stream_open(inode, filp);
filp->private_data = sess_data;

return 0;
--
1.8.3.1

2021-03-31 07:40:12

by Enric Balletbo i Serra

Subject: Re: [PATCH] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open

On Sun, 7 Feb 2021 17:08:38 +0800, Yang Li wrote:
> Eliminate the following coccicheck warning:
> ./drivers/platform/chrome/wilco_ec/telemetry.c:259:1-17: WARNING:
> telem_fops: .read() and .write() have stream semantic; safe to change
> nonseekable_open -> stream_open.

Applied, thanks!

[1/1] platform/chrome: wilco_ec: convert stream-like files from nonseekable_open -> stream_open
commit: dbc334fb411f2e87ca0e812dc7ba13464aa89504

Best regards,
--
Enric Balletbo i Serra <[email protected]>