2021-02-08 10:42:00

by Yang Li

Subject: [PATCH] selftests: bpf: remove unneeded semicolon

Eliminate the following coccicheck warning:
./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
semicolon

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
index 01f0c63..571cc07 100644
--- a/tools/testing/selftests/bpf/test_flow_dissector.c
+++ b/tools/testing/selftests/bpf/test_flow_dissector.c
@@ -503,7 +503,7 @@ static int do_rx(int fd)
if (rbuf != cfg_payload_char)
error(1, 0, "recv: payload mismatch");
num++;
- };
+ }

return num;
}
--
1.8.3.1

2021-02-09 02:07:07

by Andrii Nakryiko

Subject: Re: [PATCH] selftests: bpf: remove unneeded semicolon

On Mon, Feb 8, 2021 at 2:30 AM Yang Li <[email protected]> wrote:
>
> Eliminate the following coccicheck warning:
> ./tools/testing/selftests/bpf/test_flow_dissector.c:506:2-3: Unneeded
> semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>
> ---

Applied to bpf-next, changing subject to have more canonical
"selftests/bpf: " prefix. Thanks.

> tools/testing/selftests/bpf/test_flow_dissector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/testing/selftests/bpf/test_flow_dissector.c b/tools/testing/selftests/bpf/test_flow_dissector.c
> index 01f0c63..571cc07 100644
> --- a/tools/testing/selftests/bpf/test_flow_dissector.c
> +++ b/tools/testing/selftests/bpf/test_flow_dissector.c
> @@ -503,7 +503,7 @@ static int do_rx(int fd)
> if (rbuf != cfg_payload_char)
> error(1, 0, "recv: payload mismatch");
> num++;
> - };
> + }
>
> return num;
> }
> --
> 1.8.3.1
>