2021-02-08 09:57:52

by Jiapeng Chong

Subject: [PATCH] bpf: Simplify bool comparison

Fix the following coccicheck warning:

./tools/bpf/bpf_dbg.c:893:32-36: WARNING: Comparison to bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
tools/bpf/bpf_dbg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/bpf/bpf_dbg.c b/tools/bpf/bpf_dbg.c
index a0ebcdf..a07dfc4 100644
--- a/tools/bpf/bpf_dbg.c
+++ b/tools/bpf/bpf_dbg.c
@@ -890,7 +890,7 @@ static int bpf_run_stepping(struct sock_filter *f, uint16_t bpf_len,
bool stop = false;
int i = 1;

- while (bpf_curr.Rs == false && stop == false) {
+ while (!bpf_curr.Rs && !stop) {
bpf_safe_regs();

if (i++ == next)
--
1.8.3.1

2021-02-09 02:04:03

by patchwork-bot+netdevbpf

Subject: Re: [PATCH] bpf: Simplify bool comparison

Hello:

This patch was applied to bpf/bpf-next.git (refs/heads/master):

On Mon, 8 Feb 2021 17:43:36 +0800 you wrote:
> Fix the following coccicheck warning:
>
> ./tools/bpf/bpf_dbg.c:893:32-36: WARNING: Comparison to bool.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
>
> [...]

Here is the summary with links:
- bpf: Simplify bool comparison
https://git.kernel.org/bpf/bpf-next/c/0a1b0fd929a8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html