2021-02-09 10:28:16

by Jiapeng Chong

Subject: [PATCH] irqchip/csky: Use true and false for bool variable

Fix the following coccicheck warning:

./drivers/irqchip/irq-csky-apb-intc.c:139:9-10: WARNING: return of 0/1
in function 'handle_irq_perbit' with return type bool.

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/irqchip/irq-csky-apb-intc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-csky-apb-intc.c b/drivers/irqchip/irq-csky-apb-intc.c
index 5a2ec43..5e18ba9 100644
--- a/drivers/irqchip/irq-csky-apb-intc.c
+++ b/drivers/irqchip/irq-csky-apb-intc.c
@@ -136,11 +136,11 @@ static inline bool handle_irq_perbit(struct pt_regs *regs, u32 hwirq,
u32 irq_base)
{
if (hwirq == 0)
- return 0;
+ return false;

handle_domain_irq(root_domain, irq_base + __fls(hwirq), regs);

- return 1;
+ return true;
}

/* gx6605s 64 irqs interrupt controller */
--
1.8.3.1

2021-02-09 16:03:06

by Guo Ren

Subject: Re: [PATCH] irqchip/csky: Use true and false for bool variable

Looks good to me, thx.

On Tue, Feb 9, 2021 at 6:08 PM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following coccicheck warning:
>
> ./drivers/irqchip/irq-csky-apb-intc.c:139:9-10: WARNING: return of 0/1
> in function 'handle_irq_perbit' with return type bool.
>
> Reported-by: Abaci Robot<[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/irqchip/irq-csky-apb-intc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/irq-csky-apb-intc.c b/drivers/irqchip/irq-csky-apb-intc.c
> index 5a2ec43..5e18ba9 100644
> --- a/drivers/irqchip/irq-csky-apb-intc.c
> +++ b/drivers/irqchip/irq-csky-apb-intc.c
> @@ -136,11 +136,11 @@ static inline bool handle_irq_perbit(struct pt_regs *regs, u32 hwirq,
> u32 irq_base)
> {
> if (hwirq == 0)
> - return 0;
> + return false;
>
> handle_domain_irq(root_domain, irq_base + __fls(hwirq), regs);
>
> - return 1;
> + return true;
> }
>
> /* gx6605s 64 irqs interrupt controller */
> --
> 1.8.3.1
>


--
Best Regards
Guo Ren

ML: https://lore.kernel.org/linux-csky/