2021-02-10 08:39:35

by Jiapeng Chong

Subject: [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable

Fix the following coccicheck warning:

./include/linux/mfd/db8500-prcmu.h:723:8-9: WARNING: return of 0/1 in
function 'db8500_prcmu_is_ac_wake_requested' with return type bool.

Reported-by: Abaci Robot<[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
include/linux/mfd/db8500-prcmu.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/mfd/db8500-prcmu.h b/include/linux/mfd/db8500-prcmu.h
index 4b63d3e..a62de3d 100644
--- a/include/linux/mfd/db8500-prcmu.h
+++ b/include/linux/mfd/db8500-prcmu.h
@@ -720,7 +720,7 @@ static inline int db8500_prcmu_load_a9wdog(u8 id, u32 val)

static inline bool db8500_prcmu_is_ac_wake_requested(void)
{
- return 0;
+ return false;
}

static inline int db8500_prcmu_set_arm_opp(u8 opp)
--
1.8.3.1

2021-03-08 13:30:04

by Lee Jones

Subject: Re: [PATCH] mfd: dbx500-prcmu: Use true and false for bool variable

On Wed, 10 Feb 2021, Jiapeng Chong wrote:

> Fix the following coccicheck warning:
>
> ./include/linux/mfd/db8500-prcmu.h:723:8-9: WARNING: return of 0/1 in
> function 'db8500_prcmu_is_ac_wake_requested' with return type bool.
>
> Reported-by: Abaci Robot<[email protected]>

This needs a ' ' before the '<'.

> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> include/linux/mfd/db8500-prcmu.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I fixed the above and applied the patch, thanks.

--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog