2021-02-11 03:58:53

by Jonathan Marek

[permalink] [raw]
Subject: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7

Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Fixes: 06369bcc15a1 ("regulator: qcom-rpmh: Add support for SM8150")
Signed-off-by: Jonathan Marek <[email protected]>
---
drivers/regulator/qcom-rpmh-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
index 05f1b4e150f4..043dc2fd39eb 100644
--- a/drivers/regulator/qcom-rpmh-regulator.c
+++ b/drivers/regulator/qcom-rpmh-regulator.c
@@ -937,7 +937,7 @@ static const struct rpmh_vreg_init_data pm8009_vreg_data[] = {
RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l4"),
RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo, "vdd-l5-l6"),
RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo, "vdd-l5-l6"),
- RPMH_VREG("ldo7", "ldo%s6", &pmic5_pldo_lv, "vdd-l7"),
+ RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7"),
{},
};

--
2.26.1


2021-02-11 04:40:58

by Vinod Koul

[permalink] [raw]
Subject: Re: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7

On 10-02-21, 22:49, Jonathan Marek wrote:
> Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Thanks for spotting and fixing it.

Reviewed-by: Vinod Koul <[email protected]>

> Fixes: 06369bcc15a1 ("regulator: qcom-rpmh: Add support for SM8150")
> Signed-off-by: Jonathan Marek <[email protected]>
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/regulator/qcom-rpmh-regulator.c b/drivers/regulator/qcom-rpmh-regulator.c
> index 05f1b4e150f4..043dc2fd39eb 100644
> --- a/drivers/regulator/qcom-rpmh-regulator.c
> +++ b/drivers/regulator/qcom-rpmh-regulator.c
> @@ -937,7 +937,7 @@ static const struct rpmh_vreg_init_data pm8009_vreg_data[] = {
> RPMH_VREG("ldo4", "ldo%s4", &pmic5_nldo, "vdd-l4"),
> RPMH_VREG("ldo5", "ldo%s5", &pmic5_pldo, "vdd-l5-l6"),
> RPMH_VREG("ldo6", "ldo%s6", &pmic5_pldo, "vdd-l5-l6"),
> - RPMH_VREG("ldo7", "ldo%s6", &pmic5_pldo_lv, "vdd-l7"),
> + RPMH_VREG("ldo7", "ldo%s7", &pmic5_pldo_lv, "vdd-l7"),
> {},
> };
>
> --
> 2.26.1

--
~Vinod

2021-02-11 16:56:56

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] regulator: qcom-rpmh: fix pm8009 ldo7

On Wed, 10 Feb 2021 22:49:35 -0500, Jonathan Marek wrote:
> Use the correct name to avoid ldo7 commands being sent to ldo6's address.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/1] regulator: qcom-rpmh: fix pm8009 ldo7
commit: 20ccc362c3d20da734af896e075b74222589f2c0

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark