2021-02-18 11:52:33

by Jiapeng Chong

Subject: [PATCH] scsi: mvumi: Use true and false for bool variable

Fix the following coccicheck warnings:

./drivers/scsi/mvumi.c:69:9-10: WARNING: return of 0/1 in function
'tag_is_empty' with return type bool.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/scsi/mvumi.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/scsi/mvumi.c b/drivers/scsi/mvumi.c
index 71b6a1f..7cc1143 100644
--- a/drivers/scsi/mvumi.c
+++ b/drivers/scsi/mvumi.c
@@ -66,9 +66,9 @@ static void tag_release_one(struct mvumi_hba *mhba, struct mvumi_tag *st,
static bool tag_is_empty(struct mvumi_tag *st)
{
if (st->top == 0)
- return 1;
+ return true;
else
- return 0;
+ return false;
}

static void mvumi_unmap_pci_addr(struct pci_dev *dev, void **addr_array)
--
1.8.3.1

2021-03-19 03:50:32

by Martin K. Petersen

Subject: Re: [PATCH] scsi: mvumi: Use true and false for bool variable

On Thu, 18 Feb 2021 18:16:11 +0800, Jiapeng Chong wrote:

> Fix the following coccicheck warnings:
>
> ./drivers/scsi/mvumi.c:69:9-10: WARNING: return of 0/1 in function
> 'tag_is_empty' with return type bool.

Applied to 5.13/scsi-queue, thanks!

[1/1] scsi: mvumi: Use true and false for bool variable
https://git.kernel.org/mkp/scsi/c/59f90f5e6c80

--
Martin K. Petersen Oracle Linux Engineering