2021-02-22 09:50:53

by Jiapeng Chong

Subject: [PATCH] netdevsim: fib: remove unneeded semicolon

Fix the following coccicheck warnings:

./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/netdevsim/fib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
index 46fb414..11b43ce 100644
--- a/drivers/net/netdevsim/fib.c
+++ b/drivers/net/netdevsim/fib.c
@@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
err_fib6_rt_nh_del:
for (i--; i >= 0; i--) {
nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
- };
+ }
nsim_fib_rt_fini(&fib6_rt->common);
kfree(fib6_rt);
return ERR_PTR(err);
--
1.8.3.1

2021-02-22 10:05:32

by Ido Schimmel

Subject: Re: [PATCH] netdevsim: fib: remove unneeded semicolon

On Mon, Feb 22, 2021 at 05:47:04PM +0800, Jiapeng Chong wrote:
> Fix the following coccicheck warnings:
>
> ./drivers/net/netdevsim/fib.c:564:2-3: Unneeded semicolon.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/net/netdevsim/fib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/netdevsim/fib.c b/drivers/net/netdevsim/fib.c
> index 46fb414..11b43ce 100644
> --- a/drivers/net/netdevsim/fib.c
> +++ b/drivers/net/netdevsim/fib.c
> @@ -561,7 +561,7 @@ static void nsim_fib6_rt_nh_del(struct nsim_fib6_rt *fib6_rt,
> err_fib6_rt_nh_del:
> for (i--; i >= 0; i--) {
> nsim_fib6_rt_nh_del(fib6_rt, rt_arr[i]);
> - };
> + }

You can simply remove the braces since they are not needed

> nsim_fib_rt_fini(&fib6_rt->common);
> kfree(fib6_rt);
> return ERR_PTR(err);
> --
> 1.8.3.1
>